Use proper priority to deploy Vert.x Filter used for legacy websockets #48883
Conversation
We should never use the same priority value that Authorization or Authentication use as that can cause problems to other extensions - Fixes: quarkusio#48812
Status for workflow
|
| final IndexView index = indexBuildItem.getIndex(); | ||
| WebsocketClientProcessor.registerCodersForReflection(reflection, index.getAnnotations(SERVER_ENDPOINT)); | ||
|
|
||
| int priority = 1 + FilterBuildItem.AUTHORIZATION; |
There was a problem hiding this comment.
This is (old) WebSocket so it shouldn't matter and I don't know anything about it, but for record, I think it would be better if this was the opposite - 1-FilterBuildItem.AUTHORIZATION because this priority is multiplied by -1 and it means that this handler will run before the authorization handler. If they have some HTTP permissions, they will not run before WS handler.
There was a problem hiding this comment.
Feel free to open a PR in that case
There was a problem hiding this comment.
I'd have to analyze why it worked this way before (why was the priority same), how the legacy WS works etc. I don't think I'll do that. I just tried to provide information, I have no problem with keeping what you have.
We should never use the same priority value that
Authorization or Authentication use as that can
cause problems to other extensions