-
Notifications
You must be signed in to change notification settings - Fork 3k
Update maven shade plugin #48870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maven shade plugin #48870
Conversation
and also update the quarkus-grpc-protoc-plugin shade config to keep the published pom the same as with the previous version of the plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with @marko-bekhta and let's get this in.
But we need to start a separate discussion about why this shaded jar for the protoc plugin and if it should be consumed by users or not.
It's generated but not really documented. I wonder if it was supposed to replace the standard jar.
Let's get this in and then we can talk.
Status for workflow
|
🎊 PR Preview 030fbbe has been successfully built and deployed to https://quarkus-pr-main-48870-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Maven shade plugin 3.2.x wasn't really respectig the
createDependencyReducedPom
in terms that the published pom was still including the following dependencies:with the upgrade to 3.3.0+ (to 3.6.0 to be precise) the plugin respects that property and generates the pom that only contains:
removing the shaded dependencies.
So to keep things as they currently are the
createDependencyReducedPom
is flipped. Any further changes to make things cleaner will be in the followup PRs, as this one is only about the dependency update.