-
Notifications
You must be signed in to change notification settings - Fork 3k
Add the pull request template to remind about the format of linked issues #48853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the pull request template to remind about the format of linked issues #48853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added some small suggestions.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
* Resolves #yyyyy | ||
* Closes #zzzzz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather stick to Fixes for all of them.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
[Please describe here what your change is about] | ||
|
||
<!-- | ||
Please include the list of GitHub issues this Pull Request addresses in the following format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the list of GitHub issues this Pull Request addresses in the following format: | |
Please include in the description above the list of GitHub issues this Pull Request addresses in the following format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better be precise to avoid people adjusting the comment :)
f7d8a4d
to
41a6951
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Awesome, thanks! |
So that there is a reminder about the format in which issues should be linked.
Let me know if you think we should phrase it differently or include something else in the template 😃