Skip to content

Fix NPE in SnapshotTesting when src/test/resources/__snapshots__ directory isn't available #48850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fix NPE in SnapshotTesting when src/test/resources/__snapshots__ directory isn't available #48850

merged 1 commit into from
Jul 10, 2025

Conversation

aloubyansky
Copy link
Member

@ia3andy this happens in the platform tests, where snapshots are found in JARs.

@aloubyansky aloubyansky requested a review from ia3andy July 9, 2025 10:10
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 9, 2025
@aloubyansky aloubyansky mentioned this pull request Jul 9, 2025
Merged
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a741da0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 68e3dee into quarkusio:main Jul 10, 2025
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 10, 2025
@ia3andy
Copy link
Contributor

ia3andy commented Jul 11, 2025

Thanks @aloubyansky 🙏

@gsmet gsmet modified the milestones: 3.25.0.CR1, 3.24.4 Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

@ia3andy ia3andy Awaiting requested review from ia3andy

Assignees

No one assigned

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform

Projects

None yet

Milestone

3.24.4

Development

Successfully merging this pull request may close these issues.

4 participants

@aloubyansky @ia3andy @gsmet @geoand