Sync naming convention for file dependency JARs #48800

reaver585 · 2025-07-06T15:05:29Z

This makes Gradle's 'quarkusDependenciesBuild' task use same naming convention when producing jars for directory dependencies as JarResultBuildStep.

Closes: Gradle task fails to copy over sourceset jar properly #48768.

aloubyansky · 2025-07-06T19:18:18Z

Thanks @reaver585! We do want to have a test for it though. We could adapt the reproducer provided by the user or come up with one on our own. Would you like to look into that?

reaver585 · 2025-07-06T20:58:39Z

Thanks @reaver585! We do want to have a test for it though. We could adapt the reproducer provided by the user or come up with one on our own. Would you like to look into that?

@aloubyansky yeah, sure, I can do this - it will anyways be useful for me to look at how testing is generally done.
I will have a look at it tomorrow.

gsmet · 2025-07-07T07:46:19Z

FYI, I will prepare the next 3.24.x tomorrow evening Paris time and it would be great if we could merge this by then. Thanks!

reaver585 · 2025-07-07T18:12:55Z

@aloubyansky I have added the test that reproduces the issue.
Please bear in mind that it's probably not done in the nicest way since the issue only pops when quarkusRun is used, and I didn't manage to find any tests that target this task, so I still extended QuarkusDevGradleTestBase.

I'm sure it can be done in a cleaner fashion, but first, I wasn't sure it was needed since for now this is the only such test, and second, I'm not sure I could do that quickly - if we want to merge this before tomorrow's release.

cc @gsmet

reaver585 · 2025-07-07T18:24:29Z

Oh yeah, there also seems to be an issue in current main

Caused by: org.eclipse.aether.collection.DependencyCollectionException: Failed to collect dependencies at org.mvnpm.at.mvnpm:vaadin-webcomponents:jar:24.8.2 -> org.mvnpm.at.vaadin:markdown:jar:24.8.3 -> org.mvnpm.at.vaadin:component-base:jar:[24.8.3,24.9)

This happens for me locally too. Looks like markdown tries to pull in dependencies that are not available in maven central. Don't know what's the deal with that, saw other CI runs in the repo failing because of this.

ryandens · 2025-07-07T20:26:58Z

This happens for me locally too. Looks like markdown tries to pull in dependencies that are not available in maven central. Don't know what's the deal with that, say other CI runs in the repo failing because of this.

Stumbled across this issue because I was having problems with my build of main - fwiw i think this issue is caused by dynamic versions (#48761) and a recently released vaadin artifact conflicting with the quarkus bom which pins the dependency to one just below the version range: https://github.com/quarkusio/quarkus/blob/main/bom/dev-ui/pom.xml#L16

It seems like the path forward is to upgrade vaadin in the dev ui bom to 3.28.3 (which is how i was able to start building main again)

aloubyansky

Thanks a lot @reaver585 !

reaver585 · 2025-07-07T21:02:08Z

Stumbled across this issue because I was having problems with my build of main - fwiw i think this issue is caused by dynamic versions (#48761) and a recently released vaadin artifact conflicting with the quarkus bom which pins the dependency to one just below the version range: https://github.com/quarkusio/quarkus/blob/main/bom/dev-ui/pom.xml#L16

It seems like the path forward is to upgrade vaadin in the dev ui bom to 3.28.3 (which is how i was able to start building main again)

Thx for the info @ryandens.
FYI, to build locally / test this PR I downgraded vaadin version locally in dev ui bom to 24.6.6, in case that's helpful for anyone.

This makes Gradle's 'quarkusDependenciesBuild' task use same naming convention when producing jars for directory dependencies as JarResultBuildStep. Closes quarkusio#48768

aloubyansky · 2025-07-07T21:29:32Z

I just rebased this branch

reaver585 · 2025-07-07T21:30:21Z

I just rebased this branch

Thanks!

quarkus-bot · 2025-07-08T03:47:37Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 32c1d55.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 21	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: core/deployment 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 379 more

📦 core/deployment

✖ io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.test line 233 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting AtomicBoolean(false) to have value:
  true
but did not.
	at io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.assertAppModel(RetryResolutionOnMissingTmpFileErrorsTest.java:233)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.initAugmentAction(PackageAppTestBase.java:146)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.testBootstrap(PackageAppTestBase.java:156)

⚙️ JVM Tests - JDK 21 #

- Failing: core/deployment 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 379 more

📦 core/deployment

✖ io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.test line 233 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting AtomicBoolean(false) to have value:
  true
but did not.
	at io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.assertAppModel(RetryResolutionOnMissingTmpFileErrorsTest.java:233)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.initAugmentAction(PackageAppTestBase.java:146)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.testBootstrap(PackageAppTestBase.java:156)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: core/deployment 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 379 more

📦 core/deployment

✖ io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.test line 233 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting AtomicBoolean(false) to have value:
  true
but did not.
	at io.quarkus.deployment.runnerjar.RetryResolutionOnMissingTmpFileErrorsTest.assertAppModel(RetryResolutionOnMissingTmpFileErrorsTest.java:233)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.initAugmentAction(PackageAppTestBase.java:146)
	at io.quarkus.deployment.runnerjar.PackageAppTestBase.testBootstrap(PackageAppTestBase.java:156)

aloubyansky · 2025-07-08T05:50:54Z

@gsmet I'll look into RetryResolutionOnMissingTmpFileErrorsTest.

quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jul 6, 2025

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Jul 6, 2025

gsmet added the triage/backport label Jul 7, 2025

reaver585 force-pushed the sync-file-dep-jar-naming-for-gradle branch from cfd3aef to 638bc59 Compare July 7, 2025 18:10

aloubyansky approved these changes Jul 7, 2025

View reviewed changes

Sync naming convention for file dependency JARs

32c1d55

This makes Gradle's 'quarkusDependenciesBuild' task use same naming convention when producing jars for directory dependencies as JarResultBuildStep. Closes quarkusio#48768

aloubyansky force-pushed the sync-file-dep-jar-naming-for-gradle branch from 638bc59 to 32c1d55 Compare July 7, 2025 21:26

This comment has been minimized.

Sign in to view

aloubyansky approved these changes Jul 8, 2025

View reviewed changes

aloubyansky merged commit 6241ec3 into quarkusio:main Jul 8, 2025
106 of 112 checks passed

quarkus-bot bot added this to the 3.25 - main milestone Jul 8, 2025

quarkus-bot bot added the kind/bugfix label Jul 8, 2025

reaver585 deleted the sync-file-dep-jar-naming-for-gradle branch July 8, 2025 07:55

gsmet modified the milestones: 3.25 - main, 3.24.3 Jul 8, 2025

gsmet removed the triage/backport label Jul 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync naming convention for file dependency JARs #48800

Sync naming convention for file dependency JARs #48800

Uh oh!

reaver585 commented Jul 6, 2025 •

edited by geoand

Loading

Uh oh!

aloubyansky commented Jul 6, 2025

Uh oh!

reaver585 commented Jul 6, 2025

Uh oh!

This comment has been minimized.

gsmet commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025 •

edited

Loading

Uh oh!

ryandens commented Jul 7, 2025

Uh oh!

aloubyansky left a comment

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

aloubyansky commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

This comment has been minimized.

quarkus-bot bot commented Jul 8, 2025 •

edited by github-actions bot

Loading

Uh oh!

aloubyansky commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Sync naming convention for file dependency JARs #48800

Sync naming convention for file dependency JARs #48800

Uh oh!

Conversation

reaver585 commented Jul 6, 2025 • edited by geoand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aloubyansky commented Jul 6, 2025

Uh oh!

reaver585 commented Jul 6, 2025

Uh oh!

This comment has been minimized.

gsmet commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryandens commented Jul 7, 2025

Uh oh!

aloubyansky left a comment

Choose a reason for hiding this comment

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

aloubyansky commented Jul 7, 2025

Uh oh!

reaver585 commented Jul 7, 2025

Uh oh!

This comment has been minimized.

quarkus-bot bot commented Jul 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 #

📦 core/deployment

⚙️ JVM Tests - JDK 21 #

📦 core/deployment

⚙️ JVM Tests - JDK 17 Windows #

📦 core/deployment

Uh oh!

aloubyansky commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

reaver585 commented Jul 6, 2025 •

edited by geoand

Loading

reaver585 commented Jul 7, 2025 •

edited

Loading

quarkus-bot bot commented Jul 8, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`