-
Notifications
You must be signed in to change notification settings - Fork 3k
Allow dev service Startable
s to access config in native mode
#48785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dev service Startable
s to access config in native mode
#48785
Conversation
🎊 PR Preview 1801547 has been successfully built and deployed to https://quarkus-pr-main-48785-preview.surge.sh/version/main/guides/
|
9e063d0
to
86f5c14
Compare
Status for workflow
|
This is a less tactical version of https://github.com/quarkusio/quarkus/pull/48753/files#diff-53bbc5c17c7f10a6cce6c0e51e3a27e20cd64cddc5cfb9a7da3e1cf1a8e5a945L77-R88.
On the native path, the TCCL-setting in the dev service registry is a no-op, because the native method just passed it the current TCCL. I'm not totally sure what the optimum TCCL is, but I know that the TCCL of the class doing the starting works better than the current TCCL, which would be the app classloader. We can iterate on this in future PRs if we come up with something more considered.