Skip to content

Make REST Client config suffice for request/response logging #48745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Make REST Client config suffice for request/response logging #48745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ient/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/ClientBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ public class ClientBuilderImpl extends ClientBuilder {
// overridden security settings
private TlsConfig tlsConfig;

private LoggingScope loggingScope;
private ClientLogger clientLogger = new DefaultClientLogger();
private LoggingScope loggingScope = LoggingScope.NONE;
private Integer loggingBodySize = 100;

private int maxChunkSize = 8096;
private MultiQueryParamMode multiQueryParamMode;

private ClientLogger clientLogger = new DefaultClientLogger();
private String userAgent = RestClientRequestContext.DEFAULT_USER_AGENT_VALUE;

private Boolean enableCompression;
Expand Down
14 changes: 4 additions & 10 deletions ...runtime/src/main/java/org/jboss/resteasy/reactive/client/logging/DefaultClientLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,10 @@ public void setBodySize(int bodySize) {

@Override
public void logResponse(HttpClientResponse response, boolean redirect) {
if (!log.isDebugEnabled()) {
return;
}
response.bodyHandler(new Handler<>() {
@Override
public void handle(Buffer body) {
log.debugf("%s: %s %s, Status[%d %s], Headers[%s], Body:\n%s",
log.infof("%s: %s %s, Status[%d %s], Headers[%s], Body:\n%s",
redirect ? "Redirect" : "Response",
response.request().getMethod(), response.request().absoluteURI(), response.statusCode(),
response.statusMessage(), asString(response.headers()), bodyToString(body));
Expand All @@ -39,17 +36,14 @@ public void handle(Buffer body) {

@Override
public void logRequest(HttpClientRequest request, Buffer body, boolean omitBody) {
if (!log.isDebugEnabled()) {
return;
}
if (omitBody) {
log.debugf("Request: %s %s Headers[%s], Body omitted",
log.infof("Request: %s %s Headers[%s], Body omitted",
request.getMethod(), request.absoluteURI(), asString(request.headers()));
} else if (body == null || body.length() == 0) {
log.debugf("Request: %s %s Headers[%s], Empty body",
log.infof("Request: %s %s Headers[%s], Empty body",
request.getMethod(), request.absoluteURI(), asString(request.headers()));
} else {
log.debugf("Request: %s %s Headers[%s], Body:\n%s",
log.infof("Request: %s %s Headers[%s], Body:\n%s",
request.getMethod(), request.absoluteURI(), asString(request.headers()), bodyToString(body));
}
}
Expand Down
Loading