Using connection info function in StartableContainer

[holly-cummins]

Looks like a line got forgotten. I assume this is the intention?

@ozangunalp, I wasn't sure which test wasn't working/disabled from the earlier work, so I couldn't try re-enabling it, but I wondered if this fix might make a difference there? (Or it might totally not!)

[ozangunalp]

@holly-cummins that is outright wrong, I meant to return null when (connectionInfoFunction == null)

[holly-cummins]

@holly-cummins that is outright wrong, I meant to return null when (connectionInfoFunction == null)

I thought it was a strange return value, but I assumed it made sense in a kafka context, to attach directly to a container!

So should it be this?

    @Override
    public String getConnectionInfo() {
        if (connectionInfoFunction == null) {
            return null;
        }
        return connectionInfoFunction.apply(container);
    }

I'll update and push a new CI.

[ozangunalp]

@holly-cummins thanks! That was it.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5c3f1e7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.