Skip to content

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jul 2, 2025

No functional change, just a cleanup that will affect other PRs, so I'd rather send it ASAP.

@yrodiere yrodiere requested a review from marko-bekhta July 2, 2025 12:11
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/hibernate-reactive Hibernate Reactive labels Jul 2, 2025
Copy link

quarkus-bot bot commented Jul 2, 2025

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search)

Copy link

quarkus-bot bot commented Jul 2, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@yrodiere yrodiere force-pushed the hibernate-build-step-args-cleanup branch 3 times, most recently from 71390d4 to 0065498 Compare July 2, 2025 12:29

This comment has been minimized.

@yrodiere yrodiere force-pushed the hibernate-build-step-args-cleanup branch from 0065498 to ccfb49e Compare July 2, 2025 13:00

This comment has been minimized.

@yrodiere yrodiere marked this pull request as draft July 2, 2025 14:44
@yrodiere
Copy link
Member Author

yrodiere commented Jul 2, 2025

Well this didn't go well. I'll have a look.

@yrodiere yrodiere force-pushed the hibernate-build-step-args-cleanup branch from ccfb49e to 6bca79f Compare July 2, 2025 15:05
@yrodiere yrodiere marked this pull request as ready for review July 2, 2025 15:27
@yrodiere yrodiere force-pushed the hibernate-build-step-args-cleanup branch from 6bca79f to c626ffe Compare July 2, 2025 15:34
Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 🎉
removing code is always nice 😁

Copy link

quarkus-bot bot commented Jul 2, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c626ffe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere merged commit 9332405 into quarkusio:main Jul 3, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/hibernate-search Hibernate Search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants