-
Notifications
You must be signed in to change notification settings - Fork 3k
Drop @ConfigRoot config classes implementation #48717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 PR Preview 25d30a3 has been successfully built and deployed to https://quarkus-pr-main-48717-preview.surge.sh/version/main/guides/
|
2d0315e
to
69292ca
Compare
69292ca
to
b2c5b3c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b2c5b3c
to
42379a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is fine but I want us to wait until we branch 3.25 before merging.
Sure. I've moved it out of draft to have a proper CI build. Sometimes fork builds have issues that don't happen on the main CI. |
This is a follow-up of quarkusio#48717 and should only be merged when 3.25 is branched.
@radcortez I just merged 3.25 so we can rebase this one and get it merged. Let's try to merge it as soon as CI is green to prevent conflicts. |
Sure, I'll fix it now. |
42379a0
to
96c9b99
Compare
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
@radcortez Merged! You might want to update the description :). |
This is a follow-up of quarkusio#48717 and should only be merged when 3.25 is branched.
@radcortez I had some additional thoughts and I would be in favor of us dropping the deprecated elements from They are confusing, and now that their support is all gone, I don't think it makes sense to keep them. People will have a compilation error and maybe we should add a small comment in WDYT? |
Sure. Here it is: #48960 |
Removes the support of
@ConfigRoot
withclass
for Config objects (deprecated since Quarkus3.19
). Config objects must be interfaces annotated with@ConfigMapping
and@ConfigRoot
to state the phase (recommended for some time now) and documented in the Extension guide: https://quarkus.io/version/3.20/guides/writing-extensions#configuration.Additionally, this also removes deprecated Config objects kept for compatibility purposes:
HttpBuildTimeConfig
(removed), must useVertxHttpBuildTimeConfig
HttpConfiguration
(removed), must useVertxHttpConfig
GlobalDevServicesConfig
(removed) must useDevServicesConfig