Skip to content

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jul 1, 2025

Removes the support of @ConfigRoot with class for Config objects (deprecated since Quarkus 3.19). Config objects must be interfaces annotated with @ConfigMapping and @ConfigRoot to state the phase (recommended for some time now) and documented in the Extension guide: https://quarkus.io/version/3.20/guides/writing-extensions#configuration.

Additionally, this also removes deprecated Config objects kept for compatibility purposes:

  • HttpBuildTimeConfig (removed), must use VertxHttpBuildTimeConfig
  • HttpConfiguration (removed), must use VertxHttpConfig
  • GlobalDevServicesConfig (removed) must use DevServicesConfig

Copy link

github-actions bot commented Jul 1, 2025

🎊 PR Preview 25d30a3 has been successfully built and deployed to https://quarkus-pr-main-48717-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@radcortez radcortez force-pushed the remove-config-root branch from 2d0315e to 69292ca Compare July 1, 2025 16:53
@radcortez radcortez marked this pull request as ready for review July 1, 2025 19:57
@radcortez radcortez force-pushed the remove-config-root branch from 69292ca to b2c5b3c Compare July 2, 2025 09:29

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine but I want us to wait until we branch 3.25 before merging.

@radcortez
Copy link
Member Author

Sure. I've moved it out of draft to have a proper CI build. Sometimes fork builds have issues that don't happen on the main CI.

@gsmet gsmet changed the title Drop @ConfigRoot config implementation Drop @ConfigRoot config classes implementation Jul 3, 2025
@gsmet gsmet added the triage/on-ice Frozen until external concerns are resolved label Jul 4, 2025
@gsmet gsmet changed the title Drop @ConfigRoot config classes implementation [3.26] Drop @ConfigRoot config classes implementation Jul 4, 2025
gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 4, 2025
This is a follow-up of quarkusio#48717
and should only be merged when 3.25 is branched.
@gsmet
Copy link
Member

gsmet commented Jul 16, 2025

@radcortez I just merged 3.25 so we can rebase this one and get it merged. Let's try to merge it as soon as CI is green to prevent conflicts.

@radcortez
Copy link
Member Author

Sure, I'll fix it now.

@radcortez radcortez force-pushed the remove-config-root branch from 42379a0 to 96c9b99 Compare July 16, 2025 12:36
Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 96c9b99.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

This comment has been minimized.

Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 96c9b99.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 99c1f2e into quarkusio:main Jul 16, 2025
112 of 113 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 16, 2025
@gsmet gsmet changed the title [3.26] Drop @ConfigRoot config classes implementation Drop @ConfigRoot config classes implementation Jul 16, 2025
@gsmet
Copy link
Member

gsmet commented Jul 16, 2025

@radcortez Merged! You might want to update the description :).

gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 16, 2025
This is a follow-up of quarkusio#48717
and should only be merged when 3.25 is branched.
@gsmet
Copy link
Member

gsmet commented Jul 16, 2025

@radcortez I had some additional thoughts and I would be in favor of us dropping the deprecated elements from @ConfigRoot.

They are confusing, and now that their support is all gone, I don't think it makes sense to keep them.

People will have a compilation error and maybe we should add a small comment in @ConfigRoot to explain the situation? Something like @ConfigRoot may now be used on interfaces annotated with @ConfigMapping. The prefix and name attributes are gone and @ConfigMapping#prefix maybe be used instead with both attribute values concatenated with a dot.

WDYT?

@radcortez
Copy link
Member Author

Sure. Here it is: #48960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants