Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 30, 2025

It comes with a version marker.

/cc @radcortez this is what I had in mind.

You're going to write a merger similar to JavadocMerger and ModelMerger but for the JSON files coming from the class loader.

There's a bit too much logic in ModelMerger to duplicate it so it probably needs to be made more generic.

I would prefer to avoid having the YAML mapper as a Dev UI dependency so we will need to extract the model and the JSON merger in a separate jar.

Happy to discuss it further with you. Note: in the end everything coming from the IDE config experiment had already been extracted, improved and merged so it should be all good for you to play with it.

It comes with a version marker.
@gsmet gsmet requested a review from radcortez June 30, 2025 17:11
Copy link

quarkus-bot bot commented Jun 30, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ea95c24.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview b1c2c06 has been successfully built and deployed to https://quarkus-pr-main-48702-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Jun 30, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ea95c24.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry-grpc-only

io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

@radcortez
Copy link
Member

Great. Thanks!

@gsmet gsmet merged commit cd14dd9 into quarkusio:main Jul 1, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants