Do not require a default datasource definition when using a MultiTenantConnectionProvider

[yrodiere]

There's definitely a lot of cleanup to do in this area, but I tried to keep the changes minimal for now... hopefully we'll be able to make configuration much simpler once we upgrade to a version of Hibernate ORM with hibernate/hibernate-orm#10424

• Closes: Do not require a default datasource definition if TenantConnectionResolver is implemented #29269

[quarkus-bot]

/cc @gsmet (hibernate-orm)

[yrodiere]

@geoand Is this because of some new rule I'm not aware of... ?

[geoand]

What are you referring to, my edit?

The reason I do that is because it makes GH UI automatically "expand" the link in the description

[yrodiere]

What are you referring to, my edit?

Yes that's what I meant.

The reason I do that is because it makes GH UI automatically "expand" the link in the description

I see, thanks. I'll try to remember.

[geoand]

👌🏽

[marko-bekhta]

looks good 😃

There's definitely a lot of cleanup to do in this area, but I tried to keep the changes minimal for now...

+1 I wish we just set the datasource name to an empty optional if there's a db multitenancy, so that we won't even get into injectDataSource in that scenario

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6dff09b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.