Skip to content

Better document priority of ServerExceptionMapper #48684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Better document priority of ServerExceptionMapper #48684

merged 1 commit into from
Jul 1, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 30, 2025 •
edited by geoand
Loading

@gsmet gsmet mentioned this pull request Jun 30, 2025
Closed
@geoand geoand changed the title Better document priority for ServerExceptionMapper Better document priority of ServerExceptionMapper Jun 30, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
FroMage
FroMage approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but we should probably add a "see also Priorities" which is always helpful.

@gsmet gsmet force-pushed the document-priority branch from e7946b4 to 6d1a483 Compare July 1, 2025 08:19
@gsmet
Copy link
Member Author

gsmet commented Jul 1, 2025

This is good, but we should probably add a "see also Priorities" which is always helpful.

Done.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 1, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 1, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6d1a483.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 47803d3 into quarkusio:main Jul 1, 2025
98 of 102 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 1, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 1, 2025
@gsmet gsmet modified the milestones: 3.25 - main, 3.24.2 Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FroMage FroMage FroMage approved these changes

@geoand geoand geoand approved these changes

Assignees

No one assigned

Labels

area/rest area/rest-client kind/enhancement New feature or request triage/flaky-test

Projects

None yet

Milestone

3.24.2

Development

Successfully merging this pull request may close these issues.

Document whether ServerExceptionMapper.priority is ascending or descending

3 participants

@gsmet @FroMage @geoand