Skip to content

Conversation

Eng-Fouad
Copy link
Contributor

I am not sure if the misconfigurations here are intended or not.

include ':dependency'
include ':included-quarkus'

dependency does not exist, while included-quarkus exists in a sub module.

cc @snazy

related #38607

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Jun 27, 2025
@Eng-Fouad Eng-Fouad mentioned this pull request Jun 27, 2025
10 tasks
@Eng-Fouad
Copy link
Contributor Author

Also not sure exactly why it worked on pre-gradle 9.0, while it failed on gradle 9.0.

@snazy
Copy link
Contributor

snazy commented Jun 27, 2025

Hm - a Gradle include 'something-that-does-not-exist' is valid and creates an "empty" project (even if it doesn't make much sense). Maybe there's something else.

@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented Jun 27, 2025

Hm - a Gradle include 'something-that-does-not-exist' is valid and creates an "empty" project (even if it doesn't make much sense). Maybe there's something else.

I think this is a new behavior in Gradle 9.0: gradle/gradle#33184

Also see: https://docs.gradle.org/current/userguide/upgrading_version_8.html#deprecated_missing_project_directory

Starting with version 9.0, Gradle will not run builds if a project directory is missing or read-only

@snazy
Copy link
Contributor

snazy commented Jun 27, 2025

Interesting, that's definitely a new behavior. But yea - why have a Gradle project w/o a directory.

This comment has been minimized.

@Eng-Fouad
Copy link
Contributor Author

cc @geoand

@geoand
Copy link
Contributor

geoand commented Jun 27, 2025

Thanks.

I can't say myself, so let's wait for @snazy

@Eng-Fouad Eng-Fouad force-pushed the gradle-deprecated-12 branch from 3f53cca to 2b998f8 Compare June 27, 2025 16:53
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 27, 2025

This comment has been minimized.

@Eng-Fouad Eng-Fouad marked this pull request as draft June 27, 2025 18:17
@Eng-Fouad Eng-Fouad force-pushed the gradle-deprecated-12 branch from 5e1990e to 2b998f8 Compare June 27, 2025 21:37
@Eng-Fouad Eng-Fouad marked this pull request as ready for review June 27, 2025 21:37
Copy link

quarkus-bot bot commented Jun 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2b998f8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Eng-Fouad Eng-Fouad requested a review from gsmet June 29, 2025 07:25
@geoand geoand merged commit 9e43424 into quarkusio:main Jun 30, 2025
38 of 39 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 30, 2025
@Eng-Fouad Eng-Fouad deleted the gradle-deprecated-12 branch June 30, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants