Do not wait for topics to created if topic check disabled #48643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcasaes
force-pushed
the
pc/dont-wait-topics-if-check-disabled
branch
2 times, most recently
from
d5d8926 to
30aa7a3
Compare
pcasaes
force-pushed
the
pc/dont-wait-topics-if-check-disabled
branch
3 times, most recently
from
8fad48c to
ae5cdcd
Compare
pcasaes
force-pushed
the
pc/dont-wait-topics-if-check-disabled
branch
from
ae5cdcd to
577b68d
Compare
gsmet
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
This looks good to me but let's wait for @ozangunalp to confirm.
ozangunalp
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
This is awesome, @pcasaes thanks for the find, fix and tests!
It was clearly a regression!
Status for workflow
|
|
Will be backported to next 3.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48642
If "check topics exists" is disabled (ie: topics-timeout is set to 0) then
waitForTopicsToBeCreatedwill do nothing (noop).