-
Notifications
You must be signed in to change notification settings - Fork 3k
Ban and remove quarkus logger in our own source #48611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ban and remove quarkus logger in our own source #48611
Conversation
8bd93d0
to
44e9126
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good and we should merge it but I would like to have #48655 in first as atm ForbiddenAPIs is run on a small subpart of the tree so there might be more changes needed here once we generalize it.
I also think once my PR is in, we should start aggressively ban everything that shouldn't be used in our tree.
At some point, we will provide specific rules but for now, let's be lenient.
44e9126
to
67e525c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased on top of my PR and this should be all good now.
It spotted several more occurrences so it was worth applying the plugin to the whole codebase.
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
See discussion here: #48432 (comment)
In order to make the ban work, I explicitly list every logger method, so that
Log
itself didn't trigger the ban. An alternative would be to had to exclude Logger itself from forbidden api checking, either with a maven exclude or@SuppressForbidden
annotation. That reduces the risk of missing one method from my list, but increases the risk of missing something else banned inLog
.While getting CI green I spotted three classes which were using
Log
. Only one of them was my fault, as far as I can tell. :)In case we want it later, this is what we maven exclude looks like: