Skip to content

Conversation

jponge
Copy link
Member

@jponge jponge commented Jun 25, 2025

This is a backport of #48486 on 3.20.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Jun 25, 2025
@quarkus-bot quarkus-bot bot changed the title Backport of #48486 on 3.20 [3.20] Backport of #48486 on 3.20 Jun 25, 2025
Copy link

quarkus-bot bot commented Jun 25, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

Copy link

quarkus-bot bot commented Jun 25, 2025

/cc @aloubyansky (3.20), @gastaldi (3.20), @gsmet (3.20), @jmartisk (3.20), @rsvoboda (3.20)

@jponge jponge changed the title [3.20] Backport of #48486 on 3.20 [3.20] Backport of 48486 on 3.20 Jun 25, 2025
@jponge
Copy link
Member Author

jponge commented Jun 25, 2025

Note: @jmartisk suggested I check the Netty / Mutiny versions across all places, so I'll likely force push at some point 😇

Also include Mutiny and Netty alignments.
@jponge jponge force-pushed the backport/3.20/48486 branch from 42b4d0c to 31e8a3b Compare June 25, 2025 12:43
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jun 25, 2025
@jponge
Copy link
Member Author

jponge commented Jun 25, 2025

Done, aligned to the correct Netty for Vert.x 4.5.16, and to Mutiny 2.9.2 which contains useful bug fixes.

@rsvoboda
Copy link
Member

@jponge about the change in AbstractResponseWrapper ... would be end user impacted aka will they need to do the same change in their code? Or it's not expected to have such code in their apps?

@jponge
Copy link
Member Author

jponge commented Jun 25, 2025

This is a breaking change in Vert.x so we had to override it here. It's not supposed to be a user-facing API.

Copy link

quarkus-bot bot commented Jun 25, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 31e8a3b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry-reactive-messaging

io.quarkus.it.opentelemetry.OpenTelemetryTestCase.testProducerConsumerTracing - History

  • java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor\#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redpandadata/redpanda:v24.1.2 at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.startKafkaDevService(DevServicesKafkaProcessor.java:105) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redpandadata/redpanda:v24.1.2
	at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.startKafkaDevService(DevServicesKafkaProcessor.java:105)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants