Expose negotiated subprotocol to client connections in WebSockets Next #48502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emattheis
force-pushed
the
wsnext-clientconnection-subprotocol
branch
7 times, most recently
from
7ec024d to
736e0e9
Compare
|
@mkouba PTAL |
mkouba
added
the
triage/waiting-for-ci
geoand
force-pushed
the
wsnext-clientconnection-subprotocol
branch
from
736e0e9 to
0c49734
Compare
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the negotiated subprotocol available to
WebSocketClientConnectionin addition toWebSocketConnectionby moving the accessor to the common interface/implementation. This is crucial for clients that can support multiple protocols and need to know which protocol was selected by the server.