Skip to content

Conversation

emattheis
Copy link
Contributor

@emattheis emattheis commented Jun 17, 2025

This PR makes some minor changes in preparation for new WebSocket::close behavior in the forthcoming Vert.x 4.5.16 release. eclipse-vertx/vert.x#5609

  • treat HttpClosedException as a "close failure"
  • introduce CloseReason constants EMPTY (matches missing or 1005 status code) and ABNORMAL (matches 1006 status code)
  • add support for configuring ClientOptions::setClosingTimeout

@emattheis emattheis force-pushed the wsnext-closing-timeout branch from 2557a48 to 92f614c Compare June 17, 2025 17:16
@gsmet gsmet requested a review from mkouba June 18, 2025 04:31
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks really good, thank you @emattheis!

@emattheis emattheis force-pushed the wsnext-closing-timeout branch from 92f614c to 50b3ab6 Compare June 18, 2025 13:15
@emattheis emattheis force-pushed the wsnext-closing-timeout branch from 50b3ab6 to e263a2b Compare June 18, 2025 13:17
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 18, 2025
Copy link

quarkus-bot bot commented Jun 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e263a2b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Jun 18, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e263a2b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

🎊 PR Preview a974533 has been successfully built and deployed to https://quarkus-pr-main-48437-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@mkouba mkouba merged commit 2c5bbae into quarkusio:main Jun 18, 2025
28 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 18, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 18, 2025
@emattheis emattheis deleted the wsnext-closing-timeout branch June 18, 2025 15:51
@gsmet gsmet modified the milestones: 3.25 - main, 3.24.2 Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants