Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 17, 2025

JUnit 5.13 has deprecated ExtensionContext.Store.CloseableResource in favor of AutoCloseable, so let's adapt our code.

This change also eliminates the following obnoxious warning:
Type implements CloseableResource but not AutoCloseable: io.quarkus.test.junit.QuarkusTestExtension$ExtensionState

JUnit 5.13 has deprecated ExtensionContext.Store.CloseableResource
in favor of AutoCloseable, so let's adapt our code.

This change also eliminates the following obnoxious warning:
`Type implements CloseableResource but not AutoCloseable: io.quarkus.test.junit.QuarkusTestExtension$ExtensionState`
@geoand geoand requested a review from gsmet June 17, 2025 08:09
Copy link

quarkus-bot bot commented Jun 17, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 915997d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@geoand geoand merged commit bed5ce2 into quarkusio:main Jun 20, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants