Skip to content

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Jun 16, 2025

In the presence of #47610, the "redis-client" tab in the dev ui disappears, and in dev mode, if you hit 'g' you no longer get the container logs. This PR moves the getContainerInfo later, to inside lambas, so that it's got the runtime info. For dev services which aren't started in deployment phase, the result of getContainerInfo in the deployment phase will always be null, which makes it a non-ideal guard to use in the deployment phase.

This doesn't change behaviour on the main paths, but allows log tabs and g for logs in the Dev UI to work.

Keeping this as its own PR to make everything easier to review.

One thing this PR does change is that the old behaviour used a map indexed by container id for the log forwarders. That would mean a maximum of one tab per container. Now, if multiple services used the same container, there would be multiple tabs. I'm not sure how likely that is. The map seems to predate the compose dev service by about three years, so it wasn't introduced to support that.

@holly-cummins holly-cummins force-pushed the allow-lazy-container-info-in-log-forwarding branch from ded7167 to e8fa94c Compare June 16, 2025 21:17
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e8fa94c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested a review from ozangunalp June 17, 2025 06:13
@ozangunalp ozangunalp merged commit 79f8071 into quarkusio:main Jun 18, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants