Refactor and extend Redis Dev Service tests #48366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
refactor-and-extend-redis-dev-service-tests
branch
from
44a8c39 to
1bb57a0
Compare
This comment has been minimized.
This comment has been minimized.
… - tests with dev-mode and continuous testing Added a test for second change that should not trigger a service recreation: DevServicesDevModeTest#testDevModeKeepsSameInstanceWhenRefreshedOnSecondChange (failing in 47610 branch, passing in main)
holly-cummins
force-pushed
the
refactor-and-extend-redis-dev-service-tests
branch
from
1bb57a0 to
d85e9bb
Compare
Status for workflow
|
ozangunalp
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into two files, tests with dev-mode and continuous testing.
Added a test for second change that should not trigger a service recreation: DevServicesDevModeTest#testDevModeKeepsSameInstanceWhenRefreshedOnSecondChange (failing in 47610 branch, passing in main)