Skip to content

Conversation

nconcetti
Copy link

@nconcetti nconcetti commented Jun 12, 2025

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Jun 12, 2025
Copy link

quarkus-bot bot commented Jun 12, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Can you replace the star imports and makes sure your code is formatted (or the CI will complain).

This comment has been minimized.

@nconcetti nconcetti requested a review from cescoffier June 13, 2025 07:52
@cescoffier
Copy link
Member

Can you squash your commits?

@nconcetti nconcetti force-pushed the fix-grpc-method-conversion branch from 5521a34 to 849f346 Compare June 16, 2025 11:25
@nconcetti
Copy link
Author

commits are squashed :)

import io.quarkus.grpc.runtime.Interceptors;
import io.vertx.core.Vertx;

import static javax.lang.model.SourceVersion.isKeyword;
Copy link
Contributor

@geoand geoand Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure we don't want this in code that runs at runtime and not build time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im afraid there is no other way at the moment without knowing the real method name. If you mean SourceVersion specifically, i agree. That could be part of this class.

Anyway, i don't know how much use the reserved-keywords support for this interceptor is, since the extension generates mutiny stubs that are uncompilable (try with something like 'Void'). Looks like this problem could be solved in a more standardized way. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for now we could just have a copy of the reserved keywords and be done with it

@nconcetti nconcetti force-pushed the fix-grpc-method-conversion branch from 849f346 to a7cca9a Compare June 17, 2025 15:35
@nconcetti nconcetti requested a review from geoand June 17, 2025 15:36

This comment has been minimized.

…reserved keywords in BlockingServerInterceptor
@nconcetti nconcetti force-pushed the fix-grpc-method-conversion branch from a7cca9a to 637bfb1 Compare June 17, 2025 20:58
@nconcetti
Copy link
Author

again, fixed code formatting for ci

This comment has been minimized.

Copy link

quarkus-bot bot commented Jun 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 637bfb1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 5771e94 into quarkusio:main Jun 18, 2025
79 of 81 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@Blocking not working on grpc service methods if method contains reserved keyword or underscore

3 participants