-
Notifications
You must be signed in to change notification settings - Fork 3k
Use lazy data for dev services in dev ui #48356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lazy data for dev services in dev ui #48356
Conversation
…ich are started post-augmentation.
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Something else that might need to change (not sure) it the log streams in Dev UI. When a Dev Service is started with a container we stream the log to Dev UI. I just want to mention it so that it's on your radar |
Thank you! I noticed that code when I was looking at something else, and thought 'ooh, must fix that,' but I don't think it made it onto my list. Will make a note of it. |
This is necessary once #47610 merges to show full data. Because dev services may not be started in the augmentation phase, we can't populate things like container ids and port numbers in the static page build.
I believe this change is a near no-op without the dev service life cycle changes. It's not beneficial, but it's also not harmful. At most it might introduce one extra call to the backend from the front end, I think? I've manually checked postgres codestart and the redis integration test and visually things are identical on
main
to what they were before:Raising it separately so that @phillip-kruger can have a good look to make sure I updated the UI in the right, idiomatic, way – and also to keep the size of #47610 manageable for review.