Conversion to SmallRye Common Process #48354

dmlloyd · 2025-06-12T19:10:36Z

Convert most usages of the JDK ProcessBuilder and exec over to smallrye-common-process.

I've run across at least one class that can't be trivially converted because it is doing something complex/crazy/etc.; these cases should be refactored and cleaned up separately. I'll list these cases here as they appear, for future reference:

io.quarkus.test.common.DefaultDockerContainerLauncher
The general io.quarkus.test.common.ArtifactLauncher paradigm

Please review not just the code changes themselves, but also give feedback on the ergonomics of the process API in these various situations.

The move is split up into one commit per class so that we can bisect any problems that arise.

See #48223 for discussion and smallrye/smallrye-common#418 for the upstream PR.

quarkus-bot · 2025-06-12T19:11:13Z

/cc @Karm (awt), @brunobat (micrometer), @ebullient (micrometer), @galderz (awt)

github-actions · 2025-06-16T14:50:14Z

🎊 PR Preview e8c4b6e has been successfully built and deployed to https://quarkus-pr-main-48354-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java

core/deployment/src/main/java/io/quarkus/deployment/util/ExecUtil.java

independent-projects/tools/utilities/src/main/java/io/quarkus/utilities/OS.java

geoand

Very nice improvement!

…ew process API

…ner` to new process API

…nerRunner` to new process API

…and` to new process API

… process API

…new process API

…avoid losing output due to goofy race condition

dmlloyd · 2025-07-10T16:01:32Z

Unfortunately, I have to push it again to resolve conflicts. But it should be OK to merge.

geoand · 2025-07-10T16:02:36Z

👍🏽

Let's merge when CI goes green

quarkus-bot · 2025-07-10T16:33:35Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 6d95873.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-07-10T19:38:14Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 6d95873.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/kafka-devservices

✖ io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752164880, id=60988c7e29ff72bf260b5b5e771e1b7077007b55d86c3216c2f576b9c5e0a72b, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/sad_wilbur], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32857, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32857, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expose-servi... - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752164880, id=60988c7e29ff72bf260b5b5e771e1b7077007b55d86c3216c2f576b9c5e0a72b, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/sad_wilbur], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32857, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32857, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Im...

📦 integration-tests/opentelemetry-grpc-only

✖ io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/kafka-devservices

✖ io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752164872, id=20fd9d2ce39d182252cec83f7003f6c5df8a7d4d021ec4587ffa24289cac613a, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/flamboyant_hermann], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32857, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32857, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expo... - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752164872, id=20fd9d2ce39d182252cec83f7003f6c5df8a7d4d021ec4587ffa24289cac613a, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/flamboyant_hermann], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32857, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32857, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal...

rsvoboda · 2025-07-22T07:27:14Z

Just for the record, this slightly changes the output generated by ComposeRunner:

3.24.4:

3.25.0.CR1:

dmlloyd · 2025-07-22T13:43:06Z

Any case where the process is normally writing to stderr, where it is not an error, should have error().logOnSuccess(false).

In this particular case, we had previously set the error stream to be redirected to output. I don't think that's the right thing here, so I'd say that this code should be changed to just log the stderr at INFO level like before.

I'll put up a PR for that.

dmlloyd · 2025-07-22T13:45:39Z

Created #49043.

quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Jun 12, 2025

dmlloyd force-pushed the process branch 3 times, most recently from 84bf53d to b6442d5 Compare June 16, 2025 14:03

geoand reviewed Jun 17, 2025

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java Show resolved Hide resolved

geoand reviewed Jun 17, 2025

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/util/ExecUtil.java Outdated Show resolved Hide resolved

geoand reviewed Jun 17, 2025

View reviewed changes

independent-projects/tools/utilities/src/main/java/io/quarkus/utilities/OS.java Outdated Show resolved Hide resolved

geoand reviewed Jun 17, 2025

View reviewed changes

geoand approved these changes Jun 17, 2025

View reviewed changes

dmlloyd force-pushed the process branch 2 times, most recently from e608f01 to 9cc465f Compare June 23, 2025 19:09

dmlloyd force-pushed the process branch from 9cc465f to b01bc27 Compare June 25, 2025 18:37

dmlloyd marked this pull request as ready for review June 25, 2025 18:38

This comment has been minimized.

Sign in to view

dmlloyd and others added 16 commits July 10, 2025 11:00

Convert io.quarkus.deployment.pkg.steps.LinuxIDUtil to new process API

1e04d63

Convert io.quarkus.deployment.pkg.steps.NativeImageBuildRunner to n…

8399286

…ew process API

Convert `io.quarkus.deployment.pkg.steps.NativeImageBuildContainerRun…

55fda62

…ner` to new process API

Convert `io.quarkus.deployment.pkg.steps.NativeImageBuildRemoteContai…

ea58b0f

…nerRunner` to new process API

Convert `io.quarkus.devtools.project.update.rewrite.QuarkusUpdateComm…

8524166

…and` to new process API

Convert io.quarkus.deployment.pkg.steps.NativeImageBuildStep to new…

cd31511

… process API

Convert io.quarkus.grpc.codegen.GrpcCodeGen to new process API

6eb37ba

Convert io.quarkus.gradle.tasks.QuarkusRun to new process API

b53ef49

Convert io.quarkus.deployment.pkg.steps.UpxCompressionBuildStep to …

5e096c7

…new process API

Convert io.quarkus.devtools.testing.WrapperRunner to new process API

67d078c

Deprecate process launching helpers

95ae389

Convert PATH crawlers to new process API

87f79bc

Neaten native image process error messages a bit

d903b55

Convert io.quarkus.cli.CliDriver to new process API

cdd5f20

Log NativeImageBuildRunner output

8d66e89

Delay reading the err stream until the test is actually running to …

6d95873

…avoid losing output due to goofy race condition

dmlloyd force-pushed the process branch from cab15a4 to 6d95873 Compare July 10, 2025 16:01

dmlloyd merged commit c779b6d into quarkusio:main Jul 10, 2025
59 checks passed

dmlloyd deleted the process branch July 10, 2025 19:36

quarkus-bot bot added this to the 3.25 - main milestone Jul 10, 2025

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 10, 2025

dmlloyd mentioned this pull request Jul 22, 2025

Handle docker-compose output more like we did before #49043

Merged

Eng-Fouad added a commit to Eng-Fouad/quarkus that referenced this pull request Aug 29, 2025

Revert makeHardLinkWindowsFallback removal quarkusio#48354

099ccf8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Conversion to SmallRye Common Process #48354

Conversion to SmallRye Common Process #48354

Uh oh!

dmlloyd commented Jun 12, 2025 •

edited

Loading

Uh oh!

quarkus-bot bot commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geoand left a comment

Uh oh!

This comment has been minimized.

dmlloyd commented Jul 10, 2025

Uh oh!

geoand commented Jul 10, 2025

Uh oh!

quarkus-bot bot commented Jul 10, 2025

Uh oh!

Uh oh!

quarkus-bot bot commented Jul 10, 2025 •

edited by github-actions bot

Loading

Uh oh!

rsvoboda commented Jul 22, 2025

Uh oh!

dmlloyd commented Jul 22, 2025

Uh oh!

dmlloyd commented Jul 22, 2025

Uh oh!

Uh oh!

Conversion to SmallRye Common Process #48354

Conversion to SmallRye Common Process #48354

Uh oh!

Conversation

dmlloyd commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quarkus-bot bot commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geoand left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

dmlloyd commented Jul 10, 2025

Uh oh!

geoand commented Jul 10, 2025

Uh oh!

quarkus-bot bot commented Jul 10, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

Uh oh!

quarkus-bot bot commented Jul 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/kafka-devservices

📦 integration-tests/opentelemetry-grpc-only

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/kafka-devservices

Uh oh!

rsvoboda commented Jul 22, 2025

Uh oh!

dmlloyd commented Jul 22, 2025

Uh oh!

dmlloyd commented Jul 22, 2025

Uh oh!

Uh oh!

dmlloyd commented Jun 12, 2025 •

edited

Loading

github-actions bot commented Jun 16, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Jul 10, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`