Use production dependency model for remote-dev #48331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
aloubyansky
added
triage/backport-3.20
triage/backport-3.23
and removed
area/core
area/maven
area/testing
area/devtools
quarkus-bot
bot
added
area/core
area/devtools
|
@mkouba you might be interested in this failure |
@aloubyansky I've never seen this before and this particular test didn't fail yet. Also I wasn't able to reproduce it locally (using your branch). Could you pls apply the following patch so that we could identify the problematic piece of code on CI? diff --git a/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Injection.java b/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Injection.java
index 25337632031..b539608784e 100644
--- a/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Injection.java
+++ b/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Injection.java
@@ -457,6 +457,9 @@ static Injection forInvokerArgumentLookups(ClassInfo targetBeanClass, MethodInfo
public Injection(AnnotationTarget target, List<InjectionPointInfo> injectionPoints) {
this.target = target;
this.injectionPoints = injectionPoints;
+ if (injectionPoints.stream().anyMatch(ip -> ip == null)) {
+ throw new IllegalArgumentException("Null injection point detected for " + target);
+ }
}
boolean isMethod() { |
|
@mkouba would you like this change to be merged into the main branch? |
I'd like to find the problem first but yes, it might be useful. |
|
I suspect it might just be a rare glitch |
aloubyansky
force-pushed
the
remote-dev-normal-model
branch
from
c4e1257 to
9abbd09
Compare
Ok, let's keep the assert then... |
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
remote-dev-normal-model
branch
from
9abbd09 to
2fc6d8f
Compare
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
remote-dev-normal-model
branch
from
2fc6d8f to
98e326b
Compare
This comment has been minimized.
This comment has been minimized.
|
@aloubyansky from what I can see, the failures are in the added test. |
|
Yes, they are. And I don't think they are exactly caused by the changes but I'm still looking into it. |
|
The reason the new test is failing on Windows is due to a a failure to delete a JAR due to it being locked (something else has it "open"). |
aloubyansky
force-pushed
the
remote-dev-normal-model
branch
from
98e326b to
21cb2fe
Compare
This comment has been minimized.
This comment has been minimized.
|
The CI looks good. This is ready for review. It fixes more issues than originally reported in the issue referenced in the description. |
Status for workflow
|
gsmet
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48198
It fixes a few issues:
mutable-jaris a production packaging);classes) merging content of all the local dependencies in a single JAR and linking to it from multipleResolvedDependencys;appmodel.datupdate to trigger a restart instead of thedeployment-class-path.dat, since theappmodel.datincludes information about the reloadable dependencies that would need to be updated on the remote side by the client requiring a restart.