-
Notifications
You must be signed in to change notification settings - Fork 3k
Exclude Redis dev mode tests in dev mode to avoid classloading chaos #48311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Redis dev mode tests in dev mode to avoid classloading chaos #48311
Conversation
Status for workflow
|
#quarkus.redis.devservices.enabled=true | ||
|
||
# When running this project itself in dev or test mode, don't try and layer in the dev mode tests | ||
quarkus.test.exclude-pattern=io.quarkus.redis.devservices.continuoustesting.it.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But don't you exclude them already from the Surefire run:
quarkus/integration-tests/redis-devservices/pom.xml
Lines 139 to 160 in ad52ba5
<execution> | |
<id>default-test</id> | |
<goals> | |
<goal>test</goal> | |
</goals> | |
<configuration> | |
<excludes> | |
<exclude>**/continuoustesting/**/*.java</exclude> | |
</excludes> | |
</configuration> | |
</execution> | |
<execution> | |
<id>devmode-test</id> | |
<goals> | |
<goal>test</goal> | |
</goals> | |
<configuration> | |
<includes> | |
<include>**/continuoustesting/**/*.java</include> | |
</includes> | |
</configuration> | |
</execution> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the maven side is working fine. The scenario being supported here is running the tests directly in dev mode; that is, cd integration-tests/redis-devservices; mvn quarkus:dev
. It turns out that this is useful to do because this drives dev mode and continuous testing harder than the dev mode and continuous tests do, and can find some defects/help debug issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally things would work even without the exclude, but continuous-testing-in-continuous-testing is a pretty high bar. 😵💫
As suggested by @ozangunalp.
Avoids these errors:
The errors aren't great, and ideally we'd fix them, but running continuous testing tests in continuous testing mode isn't something we'd normally expect to be able to do.