Skip to content

OIDC Client: Add periodic asynchronous tokens refresh for performance critical applications #48296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

OIDC Client: Add periodic asynchronous tokens refresh for performance critical applications #48296

merged 1 commit into from
Jun 11, 2025
+384 −95

Conversation

michalvavrik
Copy link
Member

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/oidc labels Jun 9, 2025
@michalvavrik michalvavrik requested a review from sberyozkin June 9, 2025 17:51
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@michalvavrik
Copy link
Member Author

Seems like io.quarkus.it.keycloak.OidcClientTest.testEchoWithRefreshInterval that I have added in this PR is flaky, I'll check why.

@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from a6687c2 to 8f00d5d Compare June 10, 2025 08:17
@michalvavrik
Copy link
Member Author

I can't reproduce it, so I guessed why is it flaky in CI and made adjustment, let see.

@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from 8f00d5d to 50d3e35 Compare June 10, 2025 08:26
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from 50d3e35 to 5320f26 Compare June 10, 2025 09:05
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from 5320f26 to 04489a4 Compare June 10, 2025 10:22
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@sberyozkin
Copy link
Member

@michalvavrik I think it looks good, thanks, I'm just not certain about the general refactoring where most of the OidcClientRecorder got moved to OidcClientsImpl...

@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from 04489a4 to 5e3b958 Compare June 10, 2025 18:48
@michalvavrik michalvavrik requested a review from sberyozkin June 10, 2025 18:49
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
Copy link
Member Author

Looks like the added test is not flaky anymore (as this is second push without the failure).

sberyozkin
sberyozkin approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik, please only tune JavaDocs for the property a little bit

@michalvavrik michalvavrik force-pushed the feature/oidc-client-refresh-timer branch from 5e3b958 to 5f87344 Compare June 11, 2025 13:45
@michalvavrik michalvavrik added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 11, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 11, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5f87344.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5f87344.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 1808caa into quarkusio:main Jun 11, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 11, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 11, 2025
@michalvavrik michalvavrik deleted the feature/oidc-client-refresh-timer branch June 12, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees

No one assigned

Labels

area/docstyle issues related for manual docstyle review area/documentation area/oidc kind/enhancement New feature or request release/noteworthy-feature triage/flaky-test

Projects

None yet

Milestone

3.25.0.CR1

Development

Successfully merging this pull request may close these issues.

Add optional refresh token timer to OIDC client

2 participants

@michalvavrik @sberyozkin