Skip to content

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 6, 2025

Fixes #36922

No breaking change, no migration guide entry.

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Jun 6, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2025

/cc @gsmet (hibernate-orm)

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

🎊 PR Preview e19d60e has been successfully built and deployed to https://quarkus-pr-main-48265-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

Copy link

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done.

@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member Author

yrodiere commented Jun 6, 2025

I was told in https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/hibernate.2Equery.2Efail_on_pagination_over_collection_fetch/with/522760198 that the performance issue can (and maybe is) mitigated with some automatic override of the JDBC fetch size.
So, I'll set the default to false for now. At least it can be overriden easily in applications :)

@yrodiere yrodiere changed the title Add setting quarkus.hibernate-orm.query.fail-on-pagination-over-collection-fetch and have it default to true Add setting quarkus.hibernate-orm.query.fail-on-pagination-over-collection-fetch Jun 6, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c314a38.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c314a38.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 4ed7715 into quarkusio:main Jun 8, 2025
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone Jun 8, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hibernate.query.fail_on_pagination_over_collection_fetch property

4 participants