Skip to content

Conversation

DavideD
Copy link
Contributor

@DavideD DavideD commented Jun 5, 2025

Should work now.

fixes part of #31974
and it's related to #28629

I've collected some of the initialization in the HibernateProcessorUtil class.

I expected hibernate/hibernate-reactive#742 to be solved, but it's still a problem.

DavideD added 2 commits June 5, 2025 17:13
The goal is to have the common configuration for Hibernate ORM
and Hibernate Reactive so that initialization is consistent
between the two
The configuration of Hibernate ORM and Hibernate Reactive
processors will use the same method in HibernateProcessorUtil
when possible.

The original issue (quarkusio#31974) was about the dialect initialization,
but I moved more configuration properties because it made sense
(quarkusio#28629).
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Jun 5, 2025
Copy link

quarkus-bot bot commented Jun 5, 2025

/cc @gsmet (hibernate-orm)

@DavideD DavideD changed the title 31974 v3 Collect the configuration of the Hibernate ORM and Reactive processors Jun 5, 2025
Copy link

quarkus-bot bot commented Jun 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8af7560.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi requested a review from yrodiere June 5, 2025 17:02
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will probably fix a few unreported problems in the Reactive extension.

It'll also conflict with a lot of pending PRs, but, well, such is life.

@yrodiere
Copy link
Member

yrodiere commented Jun 6, 2025

Note #31974 is not fixed entirely by this PR, we still need to look into this:

Need to investigate test which was disabled in f6584a1 ( See comments in extensions/panache/hibernate-reactive-rest-data-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/rest/data/panache/deployment/openapi/OpenApiIntegrationTest.java)

But that can be a follow-up PR. Merging!

@yrodiere yrodiere merged commit 2d3e089 into quarkusio:main Jun 6, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone Jun 6, 2025
@DavideD
Copy link
Contributor Author

DavideD commented Jun 6, 2025

I forgot to attach this PR to #31974, but I don't have permissions to do it.
Can sombody do it, please?

@DavideD
Copy link
Contributor Author

DavideD commented Jun 6, 2025

Note #31974 is not fixed entirely by this PR, we still need to look into this:

Need to investigate test which was disabled in f6584a1 ( See comments in extensions/panache/hibernate-reactive-rest-data-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/rest/data/panache/deployment/openapi/OpenApiIntegrationTest.java)

But that can be a follow-up PR. Merging!

@yrodiere, see #48266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants