-
Notifications
You must be signed in to change notification settings - Fork 3k
Collect the configuration of the Hibernate ORM and Reactive processors #48253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The goal is to have the common configuration for Hibernate ORM and Hibernate Reactive so that initialization is consistent between the two
The configuration of Hibernate ORM and Hibernate Reactive processors will use the same method in HibernateProcessorUtil when possible. The original issue (quarkusio#31974) was about the dialect initialization, but I moved more configuration properties because it made sense (quarkusio#28629).
/cc @gsmet (hibernate-orm) |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this will probably fix a few unreported problems in the Reactive extension.
It'll also conflict with a lot of pending PRs, but, well, such is life.
Note #31974 is not fixed entirely by this PR, we still need to look into this:
But that can be a follow-up PR. Merging! |
I forgot to attach this PR to #31974, but I don't have permissions to do it. |
|
Should work now.
fixes part of #31974
and it's related to #28629
I've collected some of the initialization in the HibernateProcessorUtil class.
I expected hibernate/hibernate-reactive#742 to be solved, but it's still a problem.