Skip to content

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Jun 5, 2025

  • Allow encrypted JWT tokens
  • Allow cold-restart-resistant keys

This allows Renarde to keep working after #44272 got released, because otherwise there's no way to disable these, and both Renarde and Quarkus end up generating keys, but not setting the same properties (Quarkus did not support encrypted JWT) and not the same features (Quarkus did not support cold-restart-resistent JWT keys).

So now I've moved support for this from Renarde to Quarkus, but made both features conditional on build items, this way, non-Renarde users keep the same behaviour, until one day anyone asks for this to be made standard.

I did consider using configuration keys for this, but it would defeat the purpose of this working OOTB for users.

- Allow encrypted JWT tokens
- Allow cold-restart-resistant keys
Copy link

quarkus-bot bot commented Jun 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1babd41.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin
Copy link
Member

I think it looks good with the build items.
@mcruzdev - do you agree ?

@sberyozkin
Copy link
Member

@mcruzdev Hi, I'm going to merge, let us know later what you think, when you get a chance. With the build items it should be just fine

@sberyozkin sberyozkin merged commit 6d3fb34 into quarkusio:main Jun 6, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone Jun 6, 2025
@gsmet gsmet modified the milestones: 3.24 - main, 3.23.3 Jun 10, 2025
@mcruzdev
Copy link
Contributor

mcruzdev commented Jun 27, 2025

@sberyozkin sorry for delay, I simply missed this pull request in my notifications, I loved this approach/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants