Skip to content

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jun 5, 2025

This config quarkus.dev-ui.allow-extension-management=false will disable the extension management feature in dev ui

This comment has been minimized.

Copy link

github-actions bot commented Jun 5, 2025

🎊 PR Preview 820127f has been successfully built and deployed to https://quarkus-pr-main-48235-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@gastaldi gastaldi requested a review from Copilot June 5, 2025 14:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a configuration option (quarkus.dev-ui.allow-extension-management) to disable the extension management feature in the Dev UI.

  • Adds a check on the client side (qwc-extensions.js) to conditionally load extension data.
  • Modifies the server-side processor (ExtensionsProcessor.java) to pass the configuration, and adds a corresponding property in DevUIConfig.java.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js Imports and conditionally uses the allowExtensionManagement flag to control client-side behavior.
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/menu/ExtensionsProcessor.java Updates methods to pass and check the configuration flag for extension management.
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/DevUIConfig.java Introduces a new configuration property with default value.
Comments suppressed due to low confidence (1)

extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/DevUIConfig.java:55

  • [nitpick] Consider expanding the documentation to clarify that setting this property to false will disable client-side extension management features in the Dev UI.
/** Enable/Disable the ability to add and remove extension from Dev UI */

@phillip-kruger phillip-kruger force-pushed the dev-ui-disable-add-ext branch from 4d61b03 to 09e4e7a Compare June 5, 2025 22:57
@phillip-kruger phillip-kruger force-pushed the dev-ui-disable-add-ext branch from 09e4e7a to 7b613ec Compare June 5, 2025 23:02
Copy link

quarkus-bot bot commented Jun 5, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7b613ec.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 5, 2025
Copy link

quarkus-bot bot commented Jun 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7b613ec.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@phillip-kruger phillip-kruger merged commit a12de02 into quarkusio:main Jun 6, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone Jun 6, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable "registry.quarkus.io"

3 participants