-
Notifications
You must be signed in to change notification settings - Fork 3k
Add config option to disable extension management in dev ui #48235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to disable extension management in dev ui #48235
Conversation
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview 820127f has been successfully built and deployed to https://quarkus-pr-main-48235-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/DevUIConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a configuration option (quarkus.dev-ui.allow-extension-management) to disable the extension management feature in the Dev UI.
- Adds a check on the client side (qwc-extensions.js) to conditionally load extension data.
- Modifies the server-side processor (ExtensionsProcessor.java) to pass the configuration, and adds a corresponding property in DevUIConfig.java.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js | Imports and conditionally uses the allowExtensionManagement flag to control client-side behavior. |
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/menu/ExtensionsProcessor.java | Updates methods to pass and check the configuration flag for extension management. |
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/DevUIConfig.java | Introduces a new configuration property with default value. |
Comments suppressed due to low confidence (1)
extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/DevUIConfig.java:55
- [nitpick] Consider expanding the documentation to clarify that setting this property to false will disable client-side extension management features in the Dev UI.
/** Enable/Disable the ability to add and remove extension from Dev UI */
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js
Outdated
Show resolved
Hide resolved
...ertx-http/deployment/src/main/java/io/quarkus/devui/deployment/menu/ExtensionsProcessor.java
Outdated
Show resolved
Hide resolved
4d61b03
to
09e4e7a
Compare
Signed-off-by: Phillip Kruger <[email protected]>
09e4e7a
to
7b613ec
Compare
Status for workflow
|
Status for workflow
|
This config
quarkus.dev-ui.allow-extension-management=false
will disable the extension management feature in dev ui