-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix Platform overriding of codestart dockerfile data #48181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need the Platform to override the values in the codestart data, and for that, they need to be prefixed by the codestart name. TBH, my first inclination was to always override properties in the codestarts with what comes from the data... but it breaks a test so let's not go there for now. Also fix the native-micro entry as it was missing a `.from`. And make sure the data coming from previous platforms is properly fixed when extracted. Fixes quarkusio#48102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | Native Tests - Data2 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | Native Tests - Data7 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Integration Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
✔️ | JVM Integration Tests - JDK 17 Windows | Logs | Raw logs | 🔍 | ||
✖ | JVM Integration Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 21 #
- Failing: extensions/jdbc/jdbc-db2/deployment
📦 extensions/jdbc/jdbc-db2/deployment
✖ io.quarkus.jdbc.db2.deployment.DevServicesDB2DatasourceTestCase.
- History - More details - Source on GitHub
java.lang.RuntimeException:
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=icr.io/db2_community/db2:12.1.0.0, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@6ab2bde1)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:385)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:134)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io....
⚙️ JVM Tests - JDK 17 Windows #
- Failing: extensions/smallrye-openapi/deployment
! Skipped: devtools/bom-descriptor-json extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 58 more
📦 extensions/smallrye-openapi/deployment
✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project quarkus-smallrye-openapi-deployment:
See D:\a\quarkus\quarkus\extensions\smallrye-openapi\deployment\target\surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process
⚙️ Native Tests - Data2 #
- Failing: integration-tests/jpa-db2
📦 integration-tests/jpa-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error
⚙️ Native Tests - Data7 #
- Failing: integration-tests/hibernate-reactive-db2 integration-tests/reactive-db2-client
📦 integration-tests/hibernate-reactive-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error
📦 integration-tests/reactive-db2-client
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error
⚙️ JVM Integration Tests - JDK 17 #
- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2 integration-tests/reactive-db2-client
📦 integration-tests/hibernate-reactive-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error
📦 integration-tests/jpa-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error
📦 integration-tests/reactive-db2-client
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error
⚙️ JVM Integration Tests - JDK 21 #
- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2 integration-tests/reactive-db2-client
📦 integration-tests/hibernate-reactive-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error
📦 integration-tests/jpa-db2
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error
📦 integration-tests/reactive-db2-client
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error
@holly-cummins I wonder if we don't have a metaspace leak somewhere. The |
We need the Platform to override the values in the codestart data, and for that, they need to be prefixed by the codestart name. TBH, my first inclination was to always override properties in the codestarts with what comes from the data... but it breaks a test so let's not go there for now.
Also fix the native-micro entry as it was missing a
.from
.And make sure the data coming from previous platforms is properly fixed when extracted.
Fixes #48102
Problem is due to the
tooling-dockerfiles
codestart.yml
containing the default values fornative
andnative-micro
so we need to make sure they are properly overridden: