Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 2, 2025

We need the Platform to override the values in the codestart data, and for that, they need to be prefixed by the codestart name. TBH, my first inclination was to always override properties in the codestarts with what comes from the data... but it breaks a test so let's not go there for now.

Also fix the native-micro entry as it was missing a .from.

And make sure the data coming from previous platforms is properly fixed when extracted.

Fixes #48102

Problem is due to the tooling-dockerfiles codestart.yml containing the default values for native and native-micro so we need to make sure they are properly overridden:

    data:
      dockerfile:
        native:
          from: registry.access.redhat.com/ubi8/ubi-minimal:8.10
        native-micro:
          from: quay.io/quarkus/quarkus-micro-image:2.0

We need the Platform to override the values in the codestart data, and
for that, they need to be prefixed by the codestart name.
TBH, my first inclination was to always override properties in the
codestarts with what comes from the data... but it breaks a test so
let's not go there for now.

Also fix the native-micro entry as it was missing a `.from`.

And make sure the data coming from previous platforms is properly fixed
when extracted.

Fixes quarkusio#48102
@gsmet gsmet requested review from aloubyansky and ia3andy June 2, 2025 13:11
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 2, 2025
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

quarkus-bot bot commented Jun 2, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e03dd1e.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
Native Tests - Data2 Build Failures Logs Raw logs 🔍
Native Tests - Data7 Build Failures Logs Raw logs 🔍
JVM Integration Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ JVM Integration Tests - JDK 17 Windows Logs Raw logs 🔍
JVM Integration Tests - JDK 21 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/jdbc/jdbc-db2/deployment 

📦 extensions/jdbc/jdbc-db2/deployment

io.quarkus.jdbc.db2.deployment.DevServicesDB2DatasourceTestCase. - History - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=icr.io/db2_community/db2:12.1.0.0, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@6ab2bde1)
	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:385)
	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:134)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io....

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: devtools/bom-descriptor-json extensions/agroal/deployment extensions/elytron-security-jdbc/deployment and 58 more

📦 extensions/smallrye-openapi/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project quarkus-smallrye-openapi-deployment:

See D:\a\quarkus\quarkus\extensions\smallrye-openapi\deployment\target\surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process


⚙️ Native Tests - Data2 #

- Failing: integration-tests/jpa-db2 

📦 integration-tests/jpa-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error


⚙️ Native Tests - Data7 #

- Failing: integration-tests/hibernate-reactive-db2 integration-tests/reactive-db2-client 

📦 integration-tests/hibernate-reactive-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error

📦 integration-tests/reactive-db2-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error


⚙️ JVM Integration Tests - JDK 17 #

- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2 integration-tests/reactive-db2-client 

📦 integration-tests/hibernate-reactive-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error

📦 integration-tests/jpa-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error

📦 integration-tests/reactive-db2-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error


⚙️ JVM Integration Tests - JDK 21 #

- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2 integration-tests/reactive-db2-client 

📦 integration-tests/hibernate-reactive-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error

📦 integration-tests/jpa-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error

📦 integration-tests/reactive-db2-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.46.0:start (docker-start) on project quarkus-integration-test-reactive-db2-client: I/O Error

@gsmet
Copy link
Member Author

gsmet commented Jun 2, 2025

@holly-cummins I wonder if we don't have a metaspace leak somewhere. The quarkus-smallrye-openapi-deployment started failing on Windows with Metaspace errors and I don't see exactly why. The first PR that triggered the error look very innocuous: #47290

@gsmet gsmet merged commit 5ecc6e1 into quarkusio:main Jun 2, 2025
52 of 58 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone Jun 2, 2025
@gsmet gsmet modified the milestones: 3.24 - main, 3.23.1 Jun 3, 2025
@jmartisk jmartisk modified the milestones: 3.23.1, 3.20.2 Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid FROM on native-micro

3 participants