Skip to content

[PoC] rule: category/java/bestpractices.xml/MissingOverride #48169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[PoC] rule: category/java/bestpractices.xml/MissingOverride #48169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e7694ae
PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin -…
May 30, 2025
3369a20
PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin -…
May 30, 2025
97a2fc1
PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin -…
May 30, 2025
1d806d9
pmd MissingOverride
Jun 1, 2025
718f3f2
pmd MissingOverride
Jun 1, 2025
28cce6b
pmd MissingOverride
Jun 1, 2025
8724095
pmd MissingOverride
Jun 1, 2025
2d798c5
pmd MissingOverride
Jun 1, 2025
4c0329e
pmd MissingOverride
Jun 1, 2025
4af8168
pmd MissingOverride
Jun 1, 2025
dbb8ebc
pmd MissingOverride
Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,44 @@
.DS_Store
target
*.iml
.idea
!.idea/runConfigurations
.settings
.project
.classpath
.vscode/
*~
local-test
out
lib
bin
!devtools/cli/distribution/java-binary/bin
dependency-reduced-pom.xml
.directory
.java-version
.graal-install
dumps
*.iml
*.log
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next one includes this right?

*.log*
*.orig
*.rej
.factorypath
graph-output.dot
*.swp
*.swo
ObjectStore
.gradle
docker/distroless/bazel-*
/.apt_generated_tests/
*.log
*.log*
nbactions.xml
nb-configuration.xml
*.swp
*~
.DS_Store
.cache
/lsp/
.classpath
.directory
.envrc
.factorypath
.goose
.goosehints
.graal-install
.gradle
.idea
.java-version
.jekyll-cache
.mvn/.develocity
.mvn/.gradle-enterprise/
.pmd/.cache
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new one.

.project
.quarkus

.goosehints
.goose
.settings
.vscode/
.apt_generated_tests/
lsp/
ObjectStore
bin
dependency-reduced-pom.xml
docker/distroless/bazel-*
dumps
graph-output.dot
lib
local-test
nb-configuration.xml
nbactions.xml
out
target
8 changes: 8 additions & 0 deletions .pmd/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0"?>
<ruleset name="Custom Rules"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
<!-- <rule ref="category/java/bestpractices.xml/MissingOverride" />-->
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<rule ref="category/java/codestyle.xml/UnnecessaryImport" />
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#48050

</ruleset>
141 changes: 66 additions & 75 deletions build-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,10 +677,65 @@
<artifactId>smallrye-certificate-generator-maven-plugin</artifactId>
<version>${smallrye-certificate-generator.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<version>3.26.0</version>
<configuration>
<analysisCache>true</analysisCache>
<analysisCacheLocation>.pmd/.cache</analysisCacheLocation>
<printFailingErrors>true</printFailingErrors>
<rulesets>
<ruleset>.pmd/ruleset.xml</ruleset>
</rulesets>
</configuration>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>2.44.4</version>
<configuration>
<formats>
<format>
<trimTrailingWhitespace/>
<!-- <endWithNewline/> -->
<indent>
<spaces>true</spaces>
<spacesPerTab>2</spacesPerTab>
</indent>
<includes>
<include>.gitignore</include>
</includes>
<excludes>
<exclude>**gradlew**</exclude>
<exclude>**mvnw**</exclude>
<exclude>extensions/panache/**/pom.xml</exclude>
<exclude>test-framework/junit5/pom.xml</exclude>
<exclude>test-framework/security/pom.xml</exclude>
</excludes>
</format>
</formats>
<java>
<eclipse>
<file>${maven.multiModuleProjectDirectory}/independent-projects/ide-config/src/main/resources/eclipse-format.xml</file>
</eclipse>
<importOrder>
<file>${maven.multiModuleProjectDirectory}/independent-projects/ide-config/src/main/resources/eclipse.importorder</file>
</importOrder>
<!-- <removeUnusedImports /> -->
<excludes>
<!-- https://github.com/diffplug/spotless/issues/2491 -->
<exclude>**/src/main/java/io/quarkus/rest/client/reactive/deployment/ClientContextResolverHandler.java</exclude>
<exclude>**/src/main/java/io/quarkus/rest/client/reactive/deployment/ClientExceptionMapperHandler.java</exclude>
<exclude>**/src/main/java/io/quarkus/rest/client/reactive/deployment/ClientRedirectHandler.java</exclude>
</excludes>
</java>
<kotlin>
<ktfmt>
<style>KOTLINLANG</style>
</ktfmt>
</kotlin>
</configuration>
</plugin>
</plugins>
</pluginManagement>
Expand All @@ -698,28 +753,13 @@
<build>
<plugins>
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<goals>
<goal>format</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
<configuration>
<removeUnused>true</removeUnused>
</configuration>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<id>sort-imports</id>
<phase>verify</phase>
<goals>
<goal>sort</goal>
<goal>apply</goal>
</goals>
</execution>
</executions>
Expand All @@ -738,77 +778,28 @@
<build>
<plugins>
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<goals>
<goal>validate</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
<configuration>
<removeUnused>true</removeUnused>
</configuration>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<id>check-imports</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>format-kotlin</id>
<activation>
<activeByDefault>true</activeByDefault>
<property>
<name>!no-format</name>
</property>
<file>
<exists>src/main/kotlin</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<executions>
<execution>
<id>format-kotlin</id>
<phase>process-sources</phase>
<phase>verify</phase>
<goals>
<goal>apply</goal>
<goal>check</goal>
</goals>
</execution>
</executions>

<configuration>
<kotlin>
<ktfmt>
<style>KOTLINLANG</style>
<!-- optional, other options are DEFAULT, DROPBOX, GOOGLE and KOTLINLANG -->
</ktfmt>

<!--
<ktfmt>
<style>DEFAULT</style> &lt;!&ndash; optional, other options are DEFAULT, DROPBOX, GOOGLE and KOTLINLANG &ndash;&gt;
</ktfmt>
-->

</kotlin>
</configuration>
</plugin>
</plugins>
</build>
Expand Down
3 changes: 1 addition & 2 deletions extensions/websockets-next/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,7 @@
<properties>
<maven.compiler.target>21</maven.compiler.target>
<maven.compiler.source>21</maven.compiler.source>
<!-- javaparser 3.25.10 used by impsort-maven-plugin does not define the "language level" for 21 -->
<!--maven.compiler.release>21</maven.compiler.release-->
<maven.compiler.release>21</maven.compiler.release>
</properties>
<build>
<plugins>
Expand Down
40 changes: 11 additions & 29 deletions independent-projects/arc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,32 +327,17 @@
<build>
<plugins>
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<phase>verify</phase>
<goals>
<goal>format</goal>
<goal>apply</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
<executions>
<execution>
<id>sort-imports</id>
<goals>
<goal>sort</goal>
</goals>
</execution>
</executions>
<configuration>
<removeUnused>true</removeUnused>
</configuration>
</plugin>
</plugins>
</build>
</profile>
Expand All @@ -367,26 +352,23 @@
<build>
<plugins>
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<phase>verify</phase>
<goals>
<goal>validate</goal>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
<configuration>
<removeUnused>true</removeUnused>
</configuration>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<executions>
<execution>
<id>check-imports</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
Expand Down
Loading