Skip to content

Conversation

emattheis
Copy link
Contributor

This PR adds a sslSession() method to the common interface and base implementation for server and client sockets. This is necessary for server or client implementations that need to enforce specific rules for TLS communications beyond the standard handshake process.

While implementing test coverage, I noticed that the existing MTLS test case was flawed due to a missing quarkus.http.ssl.client-auth=required configuration. This has been corrected.

@geoand geoand requested a review from mkouba May 30, 2025 07:12
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba mkouba added triage/waiting-for-ci Ready to merge when CI successfully finishes area/websockets labels May 30, 2025
Copy link

quarkus-bot bot commented May 30, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e42789c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit a5a1ba5 into quarkusio:main May 30, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 30, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 30, 2025
@gsmet
Copy link
Member

gsmet commented May 30, 2025

Thanks for this change! I'll push it in the next 3.23.

@emattheis emattheis deleted the expose-ssl-context-in-websocket-connection branch May 30, 2025 12:52
@gsmet gsmet modified the milestones: 3.24 - main, 3.23.1 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants