Tolerate junit-platform.properties in user code #48129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47646
Most JUnit listeners can use the service loading mechanism, without needing a
junit-platform.properties
change. The one exception is aLauncherInterceptor
. That's what the new code uses to inject a TCCL. However, after #47365, the 'main' TCCL-injecting happens using a discovery listener. There's also an adjustment that happens earlier, to support gradle (which doesn't load tests in the discovery phase). However, that adjustment doesn't need to be done using an interceptor, and it can use a normal session listener instead.With this change, there are now two session listeners, one in
junit5
and one injunit5-config
. I looked into consolidating them, but that doesn't work, because some projects use onlyjunit5-config
. I've confirmed that the two listeners should work as expected, no matter which order they're invoked in.This PR doesn't fix all problems that can be caused by user
junit-platform.properties
, just the most acute one. See #48125 for a discussion of the others.