Skip to content

Conversation

emattheis
Copy link
Contributor

This PR adds a tlsConfigurationName(String) method to the client connector interfaces, making it possible to specify the TLS configuration at runtime.

While writing the tests, I also discovered a bug causing the connector to hang indefinitely on connectAndAwait() when a TLS configuration cannot be found. I added appropriate error handling to ensure the underlying exception gets emitted instead of being swallowed by Vert.x, and some test coverage.

Copy link

quarkus-bot bot commented May 28, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8e9cff4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented May 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8e9cff4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented May 28, 2025

🙈 The PR is closed and the preview is expired.

@gsmet gsmet requested a review from mkouba May 29, 2025 09:35
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very nice contribution. Thanks @emattheis!

@mkouba mkouba merged commit 0abd32f into quarkusio:main May 29, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 29, 2025
@emattheis emattheis deleted the tls-config-in-connector branch May 29, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants