Skip to content

Conversation

gastaldi
Copy link
Contributor

From @melloware in #48039:

I do a lot of this in my apps to hide REST Services that a DEVELOPMENT ONLY.

@IfBuildProfile(anyOf = { "dev" })
public class SocketResource {

I would love it to be a constant

@IfBuildProfile(anyOf = { LaunchMode.DEV_PROFILE})
public class SocketResource {

@gastaldi gastaldi requested a review from gsmet May 28, 2025 14:29
@melloware
Copy link
Contributor

you rock!

@gsmet gsmet force-pushed the melloware-dev-profile-constant branch from f00c872 to e1d81f5 Compare May 29, 2025 08:54
Copy link

quarkus-bot bot commented May 29, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e1d81f5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry-reactive

io.quarkus.it.opentelemetry.reactive.OpenTelemetryWithSpanAtStartupTest.testGeneratedSpansUsingRestClientReactive - History

  • expected: <2> but was: <1> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at io.quarkus.it.opentelemetry.reactive.OpenTelemetryWithSpanAtStartupTest.testGeneratedSpansUsingRestClientReactive(OpenTelemetryWithSpanAtStartupTest.java:52)

@gsmet gsmet merged commit 4df6247 into quarkusio:main May 30, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 30, 2025
@gsmet gsmet modified the milestones: 3.24 - main, 3.23.1 Jun 3, 2025
@gastaldi gastaldi deleted the melloware-dev-profile-constant branch July 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants