Skip to content

Deprecate quarkus.log.console.async and add enable to it #48003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Deprecate quarkus.log.console.async and add enable to it #48003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/runtime/src/main/java/io/quarkus/runtime/logging/LogRuntimeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,16 @@ interface AsyncConfig {
/**
* Indicates whether to log asynchronously
*/
@WithParentName
@WithDefault("false")
boolean enable();

/**
* Indicates whether to log asynchronously
*/
@WithParentName
@Deprecated(forRemoval = true, since = "3.24")
Optional<Boolean> legacyEnable();

/**
* The queue length to use before flushing writing
*/
Expand Down
9 changes: 5 additions & 4 deletions core/runtime/src/main/java/io/quarkus/runtime/logging/LoggingSetupRecorder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,8 @@ private static Handler configureConsoleHandler(
consoleHandler.setErrorManager(defaultErrorManager);
applyFilter(includeFilters, defaultErrorManager, cleanupFilter, config.filter(), namedFilters, consoleHandler);

Handler handler = config.async().enable() ? createAsyncHandler(config.async(), config.level(), consoleHandler)
Handler handler = config.async().legacyEnable().orElse(config.async().enable())
? createAsyncHandler(config.async(), config.level(), consoleHandler)
: consoleHandler;

if (color && launchMode.isDevOrTest() && !config.async().enable()) {
Expand Down Expand Up @@ -708,7 +709,7 @@ private static Handler configureFileHandler(final FileConfig config, final Error
handler.getErrorManager().error("Multiple file formatters were activated", null, ErrorManager.GENERIC_FAILURE);
}

if (config.async().enable()) {
if (config.async().legacyEnable().orElse(config.async().enable())) {
return createAsyncHandler(config.async(), config.level(), handler);
}
return handler;
Expand Down Expand Up @@ -790,7 +791,7 @@ private static Handler configureSyslogHandler(final LogRuntimeConfig.SyslogConfi
ErrorManager.GENERIC_FAILURE);
}

if (config.async().enable()) {
if (config.async().legacyEnable().orElse(config.async().enable())) {
return createAsyncHandler(config.async(), config.level(), handler);
}
return handler;
Expand Down Expand Up @@ -837,7 +838,7 @@ private static Handler configureSocketHandler(final LogRuntimeConfig.SocketConfi
ErrorManager.GENERIC_FAILURE);
}

if (config.async().enable()) {
if (config.async().legacyEnable().orElse(config.async().enable())) {
return createAsyncHandler(config.async(), config.level(), handler);
}
return handler;
Expand Down
Loading