Use prometheus client v1 on Micrometer and update Micrometer to 1.15

[brunobat]

Includes:

• Upgrade to Micrometer 1.15.0
• Split IT test between with OTel and without OTel to make sure native works on both cases.
• Make sure we register http.server.requests always with the same tags. Micrometer will now send a warning if we register the same metric more than once with different Tag names.
• We will stop using the simple client and all changes based on: https://github.com/micrometer-metrics/micrometer/wiki/1.13-Migration-Guide. Namely:
  • Counters now use Longs instead of Doubles.
    Before: "registry=\"prometheus\",status=\"200\",uri=\"/example/prime/{number}\"} 2.0
    Now: "registry=\"prometheus\",status=\"200\",uri=\"/example/prime/{number}\"} 2
  • io.micrometer.prometheusmetrics.PrometheusMeterRegistry must be used instead of the old io.micrometer.prometheus.PrometheusMeterRegistry
  • io.prometheus.metrics.tracer.common.SpanContext must be used instead of the old io.prometheus.client.exemplars.ExemplarSampler
  • The new Prometheus client uses some reserved words that must not be used to name metrics, therefore some metrics were renamed. Some examples of reserved words and renamed metrics:
    • info. Before: jvm_info_total. Now: jvm_total
    • duration. Before: http_server_requests_duration_seconds. Now: http_server_requests_seconds
  • Some metrics would display Tags ending in a comma (,). This tailing comma has now been removed. Example: "hibernate_flushes_total{entityManagerFactory=\"<default>\",env=\"test\",env2=\"test\",registry=\"prometheus\",} 1.0"
  • It is no longer possible to create a metric generating Service Level Objectives and Percentiles at the same time.

IMPORTANT: This PR has a companion PR on quarkiverse's quarkus-micrometer-registry here: quarkiverse/quarkus-micrometer-registry#504

• Closes: Support io.micrometer.prometheusmetrics.PrometheusMeterRegistry #47151

[quarkus-bot]

/cc @ebullient (micrometer)

[github-actions]

🙈 The PR is closed and the preview is expired.

[karesti]

@brunobat need any help here ?

[brunobat]

I will know soon

[brunobat]

Apart from docs, this should be ready.
@karesti can you please checkout the PR and see if it does what you need?

[brunobat]

Native mode needs fixing.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f47516b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f47516b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

📦 extensions/websockets-next/deployment

✖ io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLo - History

• Messages: [c2:client1] ==> expected: <true> but was: <false> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: Messages: [c2:client1] ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.assertBroadcast(BroadcastOnOpenTest.java:105)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLo(BroadcastOnOpenTest.java:45)

---

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

✖ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_UniFailed - History

• Stream has no elements - java.lang.IllegalArgumentException

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:236)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_UniFailed(MicrometerTimedInterceptorTest.java:202)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

---

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

• Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

---

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

• Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

---

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

• Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

[brunobat]

Hi @karesti, how does it look?

[karesti]

@brunobat There have been a lot of changes, so I can't say for sure that everything is working on my side yet. I need more time to finish upgrading, and I'm also dealing with some other Quarkus-related issues. That said, I'm no longer seeing the error I was getting when building with this branch, so I think it's okay for now. If I run into any related issues, I'll report them as soon as I can.

[rsvoboda]

@brunobat please add entry into https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.25

I noticed QS is failing because of this bump, I will prepare PR and add you for review.

[brunobat]

There is a new plan, I'm going to revert this code.

[karesti]

@brunobat I'm working on the upgrade of Quarkus, is there a visibility of the new plan ?

[brunobat]

This will not be part of Quarkus 3.x core, as discussed here: #users > Micrometer Prometheus client v1.0 breaking changes @ 💬

The reason is the breaking changes that would need to be introduced. The community did not agree with this PR.
Support for the new client will only happen on Quarkus 4.x, with no timeline yet.

I'm working on a Quarkiverse extension to support this registry for the current 3.x.

[gsmet]

This PR was reverted in #48498 .