Skip to content

Conversation

appiepollo14
Copy link
Contributor

Fixes picking up the following params:

  • OutputFormat param fixed by passing it to the constructor
  • OutputFile param fixed by renaming as the local var was shadowing.

Fixes #47934

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels May 20, 2025
Copy link

quarkus-bot bot commented May 20, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

@gsmet gsmet requested a review from aloubyansky May 20, 2025 14:40
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @appiepollo14

This comment has been minimized.

* OutputFile param fixed

Fixes quarkusio#47934
@gsmet gsmet force-pushed the fix/cyclonedx-params branch from e41e1b7 to 2479563 Compare May 20, 2025 15:16
@gsmet
Copy link
Member

gsmet commented May 20, 2025

I force pushed a formatting fix.

@appiepollo14 appiepollo14 changed the title fix: Cyclonedx broken params Fixes Cyclonedx broken params May 20, 2025
Copy link

quarkus-bot bot commented May 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2479563.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Maven Tests - JDK 17 Build Failures Logs Raw logs 🔍
Maven Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Maven Tests - JDK 17 #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testAlternatePom line 526 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

io.quarkus.maven.it.DevMojoIT.testAlternatePom line 526 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

io.quarkus.maven.it.DevMojoIT.testThatSourceChangesAreDetectedOnPomChange line 490 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatSourceChangesAreDetectedOnPomChange line 490 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatTheApplicationIsReloadedOnPomChange line 547 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatTheApplicationIsReloadedOnPomChange line 547 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

⚙️ Maven Tests - JDK 17 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testAlternatePom line 526 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

io.quarkus.maven.it.DevMojoIT.testAlternatePom line 526 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

io.quarkus.maven.it.DevMojoIT.testThatSourceChangesAreDetectedOnPomChange line 490 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatSourceChangesAreDetectedOnPomChange line 490 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatTheApplicationIsReloadedOnPomChange line 547 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

io.quarkus.maven.it.DevMojoIT.testThatTheApplicationIsReloadedOnPomChange line 547 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@appiepollo14
Copy link
Contributor Author

Thanks for your early reply!

@aloubyansky
Copy link
Member

The failures are not related to these changes but we have a problem @gsmet of this kind

	Suppressed: java.util.NoSuchElementException: SRCFG00014: The config property quarkus.security.auth.enabled-in-dev-mode is required but it could not be found in any config source
		at io.smallrye.config.SmallRyeConfig.convertValue(SmallRyeConfig.java:482)
		at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:427)
		at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:406)
		at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.securityConfig(SmallRyeOpenApiProcessor.java:349)
		at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.registerAutoSecurityFilter(SmallRyeOpenApiProcessor.java:213)

@aloubyansky
Copy link
Member

I'm merging this one.

@aloubyansky aloubyansky merged commit fa80d0a into quarkusio:main May 20, 2025
55 of 57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 20, 2025
@appiepollo14 appiepollo14 deleted the fix/cyclonedx-params branch May 20, 2025 19:12
@gsmet gsmet modified the milestones: 3.24 - main, 3.23.0 May 21, 2025
@jmartisk jmartisk modified the milestones: 3.23.0, 3.20.2 Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bugfix triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CycloneDX parameters do not apply

4 participants