Refresh deleted source file location #47950

stuartwdouglas · 2025-05-20T01:01:57Z

If a kotlin file is renamed a class that was previously provided by the old file will now be provided by the new one.

This fix reloads the class file location to make sure that it is a true delete, otherwise the first reload after a rename will fail.

If a kotlin file is renamed a class that was previously provided by the old file will now be provided by the new one. This fix reloads the class file location to make sure that it is a true delete, otherwise the first reload after a rename will fail.

quarkus-bot · 2025-05-20T07:09:32Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 86c1182.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - History

expected: <1> but was: <0> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:73)

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

✖ io.quarkus.gradle.SystemPropsAsBuildTimeConfigSourceTest.testBasicMultiModuleBuild - History

Gradle build failed with exit code 137 - java.lang.AssertionError

java.lang.AssertionError: Gradle build failed with exit code 137
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:140)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:57)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:52)
	at app//io.quarkus.gradle.SystemPropsAsBuildTimeConfigSourceTest.testBasicMultiModuleBuild(SystemPropsAsBuildTimeConfigSourceTest.java:34)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:569)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.gradle.devmode.MultiCompositeBuildExtensionsDevModeTest.main - History

Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 3 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:157)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

✖ io.quarkus.gradle.SystemPropsAsBuildTimeConfigSourceTest.testBasicMultiModuleBuild - History

Gradle build failed with exit code 1 - java.lang.AssertionError

java.lang.AssertionError: Gradle build failed with exit code 1
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:140)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:57)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:52)
	at app//io.quarkus.gradle.SystemPropsAsBuildTimeConfigSourceTest.testBasicMultiModuleBuild(SystemPropsAsBuildTimeConfigSourceTest.java:34)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:569)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.gradle.devmode.MultiCompositeBuildExtensionsDevModeTest.main - History

Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:157)

⚙️ JVM Integration Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-grpc-only

✖ io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

geoand

Thanks!

aloubyansky · 2025-05-20T12:54:30Z

core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java

+            TimestampSet timestampSet, boolean forceRefresh) {
        Path sourceFilePath = timestampSet.classFilePathToSourceFilePath.get(classFilePath);
-        if (sourceFilePath == null || moduleChangedSourceFiles.contains(sourceFilePath)) {
+        if (sourceFilePath == null || moduleChangedSourceFiles.contains(sourceFilePath) || forceRefresh) {


Wouldn't !Files.exists(sourceFilePath) instead of forceRefresh achieve the same?

No, because this could result in the function returning null when previously it would have returned the non-existant file.

stuartwdouglas added the triage/backport label May 20, 2025

quarkus-bot bot added the area/core label May 20, 2025

This comment has been minimized.

Sign in to view

stuartwdouglas force-pushed the stuartwdouglas/kotlin-comp branch from e273f3b to 2a0bf8a Compare May 20, 2025 01:56

stuartwdouglas force-pushed the stuartwdouglas/kotlin-comp branch from 2a0bf8a to 86c1182 Compare May 20, 2025 03:34

quarkus-bot bot added the triage/flaky-test label May 20, 2025

geoand approved these changes May 20, 2025

View reviewed changes

geoand merged commit 201a31c into quarkusio:main May 20, 2025
58 checks passed

quarkus-bot bot added this to the 3.24 - main milestone May 20, 2025

aloubyansky reviewed May 20, 2025

View reviewed changes

gsmet modified the milestones: 3.24 - main, 3.23.0 May 20, 2025

gsmet removed the triage/backport label May 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refresh deleted source file location #47950

Refresh deleted source file location #47950

Uh oh!

stuartwdouglas commented May 20, 2025

Uh oh!

This comment has been minimized.

quarkus-bot bot commented May 20, 2025 •

edited by github-actions bot

Loading

Uh oh!

geoand left a comment

Uh oh!

Uh oh!

aloubyansky May 20, 2025

Uh oh!

stuartwdouglas May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Refresh deleted source file location #47950

Refresh deleted source file location #47950

Uh oh!

Conversation

stuartwdouglas commented May 20, 2025

Uh oh!

This comment has been minimized.

quarkus-bot bot commented May 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

⚙️ JVM Integration Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-grpc-only

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

Uh oh!

geoand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aloubyansky May 20, 2025

Choose a reason for hiding this comment

Uh oh!

stuartwdouglas May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

quarkus-bot bot commented May 20, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`