Skip to content

Conversation

yberbec
Copy link
Contributor

@yberbec yberbec commented May 18, 2025

This PR adds comprehensive JavaDoc comments to the ArchiveRootBuildItem class and its inner Builder class in order to improve code readability, maintainability, and developer experience when working with Quarkus build items.

@geoand geoand requested a review from aloubyansky May 19, 2025 08:26
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yberbec

Copy link

quarkus-bot bot commented May 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 79b9cf8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@aloubyansky aloubyansky merged commit 91ff3e7 into quarkusio:main May 20, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 20, 2025
@yberbec yberbec mentioned this pull request May 20, 2025
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants