Introduce property `quarkus.native.additional-build-args-append` #47883

zakkak · 2025-05-15T12:17:00Z

Copilot

Pull Request Overview

This PR adds support for an additional native image build argument property, "quarkus.native.additional-build-args-append", along with documentation updates and test coverage.

Updates the AsciiDoc file to explain the new property and its intended usage.
Introduces a new method in the NativeConfig interface and corresponding tests.
Modifies the native image build step to incorporate the newly added property.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
docs/src/main/asciidoc/building-native-image.adoc	Updates documentation to explain both additional-build-args and additional-build-args-append.
core/deployment/src/test/java/io/quarkus/deployment/pkg/TestNativeConfig.java	Adds a new test method for additional-build-args-append.
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java	Modifies build steps to iterate over both additional build args properties.
core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java	Introduces a new interface method for additional-build-args-append.

Comments suppressed due to low confidence (1)

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java:1066

Using a raw array for Optionals may lead to type safety warnings; consider using a List of Optionals (e.g. List<Optional<List>>) to improve clarity and type safety.

Optional<List<String>>[] additionalBuildArgs = new Optional[] { nativeConfig.additionalBuildArgs(), nativeConfig.additionalBuildArgsAppend() };

Copilot · 2025-05-15T12:17:20Z

docs/src/main/asciidoc/building-native-image.adoc

 [TIP]
 ====
-You can provide custom options for the `native-image` command using the `<quarkus.native.additional-build-args>` property.
+You can provide custom options for the `native-image` command using the `quarkus.native.additional-build-args` and `quarkus.native.additional-build-args-append` properties.


[nitpick] Consider adding a brief example of how to use the new quarkus.native.additional-build-args-append property on the command line in this documentation section to aid users in understanding its usage.

geoand · 2025-05-15T12:24:41Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

            private void handleAdditionalProperties(List<String> command) {
-                if (nativeConfig.additionalBuildArgs().isPresent()) {
-                    List<String> strings = nativeConfig.additionalBuildArgs().get();
+                Optional<List<String>>[] additionalBuildArgs = new Optional[] { nativeConfig.additionalBuildArgs(),


Optional<List<String>>[] is quite the type 😆

Yes :), even co-pilot noticed it (for different reasons though).

See "Comments suppressed due to low confidence (1)" in #47883 (review)

quarkus-bot · 2025-05-15T12:47:52Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 54cbe3a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

github-actions · 2025-05-15T12:52:13Z

🙈 The PR is closed and the preview is expired.

quarkus-bot · 2025-05-15T15:41:25Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 54cbe3a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

📦 integration-tests/opentelemetry-grpc-only

✖ io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:667)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:762)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

zakkak · 2025-05-15T16:46:28Z

CI failures are unrelated.

Introduce property quarkus.native.additional-build-args-append

54cbe3a

Closes: quarkusio#47762

zakkak requested review from Copilot and geoand May 15, 2025 12:17

quarkus-bot bot added area/core area/documentation labels May 15, 2025

Copilot AI reviewed May 15, 2025

View reviewed changes

zakkak added the area/native-image label May 15, 2025

geoand reviewed May 15, 2025

View reviewed changes

geoand approved these changes May 15, 2025

View reviewed changes

zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 15, 2025

quarkus-bot bot added the triage/flaky-test label May 15, 2025

zakkak merged commit ddd0ebc into quarkusio:main May 15, 2025
60 checks passed

quarkus-bot bot added this to the 3.24 - main milestone May 15, 2025

zakkak deleted the 2025-05-15-implement-47762 branch May 15, 2025 16:46

quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 15, 2025

jerboaa mentioned this pull request May 16, 2025

[GraalVM for JDK 24+] All native integration tests failing #47903

Closed

zakkak mentioned this pull request May 21, 2025

Enable assertions in CI runs graalvm/mandrel#846

Open

jerboaa mentioned this pull request Jun 6, 2025

GraalVM: explore flipping the default of --allow-incomplete-classpath #43409

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce property `quarkus.native.additional-build-args-append` #47883

Introduce property `quarkus.native.additional-build-args-append` #47883

Uh oh!

zakkak commented May 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 15, 2025

Uh oh!

geoand May 15, 2025 •

edited

Loading

Uh oh!

zakkak May 15, 2025

Uh oh!

quarkus-bot bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025 •

edited

Loading

Uh oh!

quarkus-bot bot commented May 15, 2025 •

edited by github-actions bot

Loading

Uh oh!

zakkak commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Introduce property quarkus.native.additional-build-args-append #47883

Introduce property quarkus.native.additional-build-args-append #47883

Uh oh!

Conversation

zakkak commented May 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 15, 2025

Choose a reason for hiding this comment

Uh oh!

geoand May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zakkak May 15, 2025

Choose a reason for hiding this comment

Uh oh!

quarkus-bot bot commented May 15, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

github-actions bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quarkus-bot bot commented May 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

📦 integration-tests/opentelemetry-grpc-only

Uh oh!

zakkak commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Introduce property `quarkus.native.additional-build-args-append` #47883

Introduce property `quarkus.native.additional-build-args-append` #47883

geoand May 15, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

github-actions bot commented May 15, 2025 •

edited

Loading

quarkus-bot bot commented May 15, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`