Make placing JPA listener annotations a little safer #47876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially handles the case where such a listener is added on private method of a CDI EntityListener class. When the listener is a @singleton we can safely transform the private method to package private, but when it's @ApplicationScoped there is nothing we can do (as any transformation we apply is invisible to Arc when it creates the Client Proxy class), so we therefore fail the build (with an actionable error message). Closes: quarkusio#24340
|
/cc @gsmet (hibernate-orm) |
|
The reason I picked this is up is that the last day or so I am going through old issues and seeing what can be done about them |
|
🙏🏽 |
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially handles the case where such a listener
is added on private method of a CDI EntityListener class.
When the listener is a
@Singletonwe can safely transformthe private method to package private, but when it's
@ApplicationScopedthere is nothing we can do(as any transformation we apply is invisible to Arc
when it creates the Client Proxy class), so we
therefore fail the build (with an actionable error
message).