-
Notifications
You must be signed in to change notification settings - Fork 3k
Do not expose Hibernate-specific metamodels through CDI #47855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @gsmet (hibernate-orm) |
3dc92e7
to
d9077b4
Compare
They are deprecated or incubating, and changes are coming in Hibernate ORM 7.0, so it's best not to rely on them for now. See https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/MappingMetamodel.20and.20JpaMetamodel/with/518018057
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Native Tests - Data2 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - Data2 #
- Failing: integration-tests/jpa
📦 integration-tests/jpa
✖ io.quarkus.it.jpa.configurationless.JPALoadScriptTestInGraalITCase.testImportExecuted
- History - More details - Source on GitHub
java.lang.AssertionError:
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "jpa=OK"
Actual: {jpa=Boooo}
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
Thanks for the approval. I'm investigating the native test failure. |
It's failing on Let's merge, as this is unrelated. I'm continuing to investigate. |
It was already fixed in #47858 , apparently. We'll see. |
👌🏽 |
They are deprecated or incubating, and changes are coming in Hibernate ORM 7.0, so it's best not to rely on them for now.
See https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/MappingMetamodel.20and.20JpaMetamodel/with/518018057
Follows up on #47792 .
Should probably be backported to 3.23.0.Final to avoid this (now removed) feature being actually used in the real world. It was introduced in 3.23.0.CR1.