Make sure we have a test compilation unit before going further #47829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also optimize things a bit when we don't have tests around. Fixes quarkusio#47794
holly-cummins
approved these changes
May 13, 2025
|
@holly-cummins you are probably more familiar with this part so feel free to push a test. I agree it would have value. |
I don't have the right permissions to be able to push to your branch, so I've (with some regret) created a new PR: #47833 I've confirmed the tests fail in the right way without your changes, and pass with your changes. We don't have many tests for continuous testing in gradle, so it was a bit of a pain to get right. In fact, we didn't have any tests for continuous testing in gradle until @Ladicek added some a while ago, so I was happy to be able to leverage @Ladicek's work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optimize things a bit when we don't have tests around.
Fixes #47794