Skip to content

Conversation

melloware
Copy link
Contributor

Based on Zulip: #dev > OpenAPI Filter enforce order with priority in extensions @ 💬

And open Quarkus Logging manager ticket: quarkiverse/quarkus-logging-manager#373

this uses the classnames to always ensure the same order when generating from OASFilters like SmallRye Health, RestEasyProblem, and Logging Manager

@gastaldi gastaldi requested a review from phillip-kruger May 9, 2025 16:43
@gastaldi
Copy link
Contributor

gastaldi commented May 9, 2025

/cc @MikeEdgar

@melloware
Copy link
Contributor Author

@MikeEdgar i realized its all extensions thta produce AddToOpenAPIDefinitionBuildItem not ones marked with @OpenApiFilter so this one is picking up all produced build items and then flickering I guess depending on the build order.

@MikeEdgar
Copy link
Contributor

@MikeEdgar i realized its all extensions thta produce AddToOpenAPIDefinitionBuildItem not ones marked with @OpenApiFilter so this one is picking up all produced build items and then flickering I guess depending on the build order.

So the issue could still occur for user filters with equal priorities in @OpenApiFilter and this just addresses extensions using the build item - got it. Thanks

Copy link

quarkus-bot bot commented May 9, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1b78d3f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 0c24090 into quarkusio:main May 9, 2025
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone May 9, 2025
@melloware melloware deleted the openapi-filter-order branch May 9, 2025 18:42
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.3 May 13, 2025
@jmartisk jmartisk modified the milestones: 3.22.3, 3.20.2 Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants