Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 8, 2025

All integration test launchers now first consult
quarkus.test.integration-test-profile and use
quarkus.profile as the fallback when determining
which profile the application should be run with.
We also make sure that the application is not
launched with multiple options specifying
what profile should be used.

geoand added 2 commits May 8, 2025 09:19
All integration test launchers now first consult
`quarkus.test.integration-test-profile` and use
`quarkus.profile` as the fallback when determining
which profile the application should be run with.
We also make sure that the application is not
launched with multiple options specifying
what profile should be used.

Fixes: quarkusio#47400
Copy link

quarkus-bot bot commented May 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 555f72c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:236)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async(MicrometerTimedInterceptorTest.java:126)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

* The profile to use when testing the native image
*/
@WithDefault("prod")
String nativeImageProfile();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for dropping this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the deprecated property that is being removed

@geoand geoand requested a review from gsmet May 12, 2025 17:36
@gsmet gsmet merged commit e4815d7 into quarkusio:main May 13, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone May 13, 2025
@rsvoboda
Copy link
Member

QS hit issue with quarkus.test.native-image-profile property drop, fixed in quarkusio/quarkus-quickstarts#1542

@geoand could you add an entry into https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.23?

@geoand
Copy link
Contributor Author

geoand commented Jun 20, 2025

Done

@geoand geoand deleted the #47400 branch June 20, 2025 06:05
@rsvoboda
Copy link
Member

Thanks @geoand

Just fyi, I moved your text out of 3.23.1 section, it's in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.23#native-image now ;)

@geoand
Copy link
Contributor Author

geoand commented Jun 20, 2025

🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to pass quarkus.profile to more than one integration test case when testing native executable

3 participants