Skip to content

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 8, 2025

This will unsign all dependency JARs when building to prevent SecurityExceptions from happening

@gastaldi gastaldi requested review from galderz and gsmet May 8, 2025 04:44
@quarkus-bot quarkus-bot bot added the area/core label May 8, 2025
@gastaldi gastaldi force-pushed the jarunsigner branch 4 times, most recently from 37d0548 to d1b8e92 Compare May 8, 2025 04:59
@gastaldi gastaldi changed the title Unsign all dependency JARs during native build Unsign all dependency JARs during build May 8, 2025
@gastaldi gastaldi requested a review from maxandersen May 8, 2025 05:04
@maxandersen
Copy link
Member

What is/was the fix ? On first glance code is just moved to another class? But otherwise called in the same places ?

This comment has been minimized.

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - i actually thought this was what we already did.

That this now unsign any signed jars (but only if signed) + That it is done using code that keep the same timestamps is a win.

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on this but have suggestion on better logging but that can be done separatly if need be.

@gastaldi gastaldi added triage/backport triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 8, 2025
Copy link

quarkus-bot bot commented May 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fdf08f0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry-grpc-only

io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:695)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:793)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

@gastaldi gastaldi merged commit 89ae963 into quarkusio:main May 8, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone May 8, 2025
@gastaldi gastaldi deleted the jarunsigner branch May 8, 2025 16:23
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 8, 2025
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.3 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native executable cannot be built with signed Jars containing beans
4 participants