-
Notifications
You must be signed in to change notification settings - Fork 3k
Unsign all dependency JARs during build #47757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37d0548
to
d1b8e92
Compare
What is/was the fix ? On first glance code is just moved to another class? But otherwise called in the same places ? |
This comment has been minimized.
This comment has been minimized.
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - i actually thought this was what we already did.
That this now unsign any signed jars (but only if signed) + That it is done using code that keep the same timestamps is a win.
core/deployment/src/main/java/io/quarkus/deployment/pkg/JarUnsigner.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on this but have suggestion on better logging but that can be done separatly if need be.
Status for workflow
|
This will unsign all dependency JARs when building to prevent
SecurityExceptions
from happening